Separate grpc server 3.5 #15589
Merged
Separate grpc server 3.5 #15589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
serathius
force-pushed
the
separate-grpc-server-3.5
branch
from
6722cb7
to
93784f6
Compare
…er separate from http server Difference in load configuration for watch delay tests show how huge the impact is. Even with random write scheduler grpc under http server can only handle 500 KB with 2 seconds delay. On the other hand, separate grpc server easily hits 10, 100 or even 1000 MB within 100 miliseconds. Priority write scheduler that was used in most previous releases is far worse than random one. Tests configured to only 5 MB to avoid flakes and taking too long to fill etcd. Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
serathius
force-pushed
the
separate-grpc-server-3.5
branch
from
93784f6
to
dfdf3db
Compare
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
serathius
force-pushed
the
separate-grpc-server-3.5
branch
from
dfdf3db
to
073c530
Compare
ahrtr
reviewed
Mar 30, 2023
| addr := sctx.addr | ||
| if network := sctx.network; network == "unix" { | ||
| // explicitly define unix network for gRPC socket support | ||
| addr = fmt.Sprintf("%s://%s", network, addr) |
There was a problem hiding this comment.
Is it because 3.5 is depending on an old gRPC version?
Suggested change
| addr = fmt.Sprintf("%s://%s", network, addr) | |
| addr = fmt.Sprintf("%s:%s", network, addr) |
There was a problem hiding this comment.
Good question, I left the code as it was as I'm just refactoring this code.
I don't expect this code path is well tested as etcd doesn't support unix sockets officially, we just implement them for testing.
tjungblu
pushed a commit
to tjungblu/etcd
that referenced
this pull request
Jul 26, 2023
Separate grpc server 3.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #15446 and #15588