tests: Deflake TestEtcdGrpcResolverRoundRobin #15795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increase request to 1000 to increase sample size/reduce variability and increase tolerance threshold from 10 to 15%. Signed-off-by: James Blair <mail@jamesblair.net>
lavacat
approved these changes
May 1, 2023
chaochn47
approved these changes
May 1, 2023
ahrtr
approved these changes
May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flake is as a result of the new test case I introduced in #15577. The test case was sending 100 requests using a round robin resolver against two endpoints and expecting roughly half to go to each server, with a 10% total tolerance (so 5% either side of 50).
In the identified flake 61 requests went to first server and 39 to the second so more than the 5% either side threshold.
To try and address that I am going to increase number of requests to 1,000 which should reduce run to run variability by increasing sample size. Additionally I will increase allowed tolerance to 15%.
These two changes in combination are expected to reduce the chance this flake can happen.
Fixes: #15794