-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests/robustness: Extract validation to separate package #16066
Conversation
4b00814
to
ae0e4ff
Compare
Benjamin is out for 2 weeks, any @etcd-io/members wants to review it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one nit. Thanks @serathius for refactoring the validation part of robustness test that improves the readability !!
5bb2e1d
to
6302ae2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Happy to have this split out.
One nitpick re consistency of validation functions.
Also need to make fix
for goimports
.
6302ae2
to
9563d58
Compare
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
9563d58
to
7bbc738
Compare
|
Yeah let me take a look at this. Agree we don't want any friction with something so basic. |
cc @ahrtr @ptabor @jmhbnz