Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/expect: avoid hardcoding when checking ErrProcessDone #16252

Merged
merged 1 commit into from
Jul 18, 2023
Merged

pkg/expect: avoid hardcoding when checking ErrProcessDone #16252

merged 1 commit into from
Jul 18, 2023

Commits on Jul 17, 2023

  1. pkg/expect: avoid hardcoding when checking ErrProcessDone 

    ExpectProcess's Stop method uses 'strings.Contains' to check
the returned err, however, this can be avoided. os.ErrProcessDone's
error message is the same as the hardcoded string. So I think
this explicit error is what this method wants to compare.

Signed-off-by: Jes Cok <xigua67damn@gmail.com>
    @callthingsoff
    callthingsoff committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    5e65553 View commit details
    Browse the repository at this point in the history