Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: pkg import more than once #16448

Merged
merged 1 commit into from
Aug 21, 2023
Merged

chore: pkg import more than once #16448

merged 1 commit into from
Aug 21, 2023

Conversation

testwill
Copy link
Contributor

@testwill
chore: pkg import more than once
f432c1c 
Signed-off-by: guoguangwu <guoguangwu@magic-shield.com>
fuweid
fuweid approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green

Thanks!

jmhbnz
jmhbnz approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @testwill

@ahrtr ahrtr merged commit e2e17c7 into etcd-io:main Aug 21, 2023
27 checks passed
@testwill testwill deleted the pkg-import branch August 21, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serathius serathius serathius approved these changes

@fuweid fuweid fuweid approved these changes

@ahrtr ahrtr ahrtr approved these changes

@jmhbnz jmhbnz jmhbnz approved these changes

Assignees
No one assigned
Labels
stage/merge-when-tests-green
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@testwill @serathius @fuweid @ahrtr @jmhbnz