Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add v3 curl test to cover all maintenance REST API #16489

Merged
merged 1 commit into from
Aug 30, 2023
Merged

test: add v3 curl test to cover all maintenance REST API #16489

merged 1 commit into from
Aug 30, 2023

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Aug 27, 2023

@ahrtr ahrtr mentioned this pull request Aug 27, 2023
Merged
jmhbnz
jmhbnz approved these changes Aug 27, 2023
View reviewed changes
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @ahrtr 👍🏻

tests/e2e/v3_curl_test.go Outdated Show resolved Hide resolved
fuweid
fuweid approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahrtr ahrtr force-pushed the maintanence_20230827 branch 2 times, most recently from 3213536 to 94d052b Compare August 28, 2023 16:31
@ahrtr
Copy link
Member Author

ahrtr commented Aug 28, 2023

@serathius PTAL

@ahrtr ahrtr mentioned this pull request Aug 30, 2023
Closed
6 tasks
@ahrtr ahrtr force-pushed the maintanence_20230827 branch 2 times, most recently from 0b38227 to 1b69881 Compare August 30, 2023 13:46
@ahrtr
test: add v3 curl test to cover all maintainence REST APIs
a733069 
Signed-off-by: Benjamin Wang <wachao@vmware.com>
@ahrtr ahrtr merged commit 2888a95 into etcd-io:main Aug 30, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serathius serathius serathius approved these changes

@fuweid fuweid fuweid approved these changes

@jmhbnz jmhbnz jmhbnz approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ahrtr @serathius @fuweid @jmhbnz