Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] dependency: September 4 2023 #16551

Closed

Conversation

sharathsivakumar
Copy link
Contributor

@ahrtr
Copy link
Member

ahrtr commented Sep 7, 2023

could you bump all dependencies in one PR (with multiple commits, each commit for one dependency)?

@ahrtr
Copy link
Member

ahrtr commented Sep 7, 2023

Also note that etcd is a multi modules project. One module indirectly depends on A, another module may directly depend on A, such as golang.org/x/sys; in such case, we need to bump A for all modules. Please read https://github.com/etcd-io/etcd/blob/main/Documentation/contributor-guide/dependency_management.md#indirect-dependencies

@ahrtr
Copy link
Member

ahrtr commented Sep 7, 2023

Please also rebase this PR, because I just merged another related PR #16357

Signed-off-by: sharathsivakumar <mailssr9@gmail.com>
Signed-off-by: sharathsivakumar <mailssr9@gmail.com>
@sharathsivakumar
Copy link
Contributor Author

@ahrtr I rebased and squashed it along with another dependency commit. Is that fine? Or is it better to rebase first and then add the dependency bot changes?

…olang.org/grpc/otelgrpc from 0.42.0 to 0.43.0

Signed-off-by: sharathsivakumar <mailssr9@gmail.com>
…lptracegrpc 1.16.0 to 1.17.0

Signed-off-by: sharathsivakumar <mailssr9@gmail.com>
@jmhbnz
Copy link
Member

jmhbnz commented Sep 7, 2023

I rebased and squashed it along with another dependency commit. Is that fine? Or is it better to rebase first and then add the dependency bot changes?

Best to rebase, then add in your dependency commits last.

@sharathsivakumar
Copy link
Contributor Author

Cool. let me do that then.

@sharathsivakumar
Copy link
Contributor Author

Done in #16552

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants