-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DRAFT] dependency: September 4 2023 #16551
[DRAFT] dependency: September 4 2023 #16551
Conversation
could you bump all dependencies in one PR (with multiple commits, each commit for one dependency)? |
Also note that etcd is a multi modules project. One module indirectly depends on A, another module may directly depend on A, such as |
Please also rebase this PR, because I just merged another related PR #16357 |
65769bf
to
046f41c
Compare
Signed-off-by: sharathsivakumar <mailssr9@gmail.com>
Signed-off-by: sharathsivakumar <mailssr9@gmail.com>
b83a7e1
to
f7c9583
Compare
@ahrtr I rebased and squashed it along with another dependency commit. Is that fine? Or is it better to rebase first and then add the dependency bot changes? |
…olang.org/grpc/otelgrpc from 0.42.0 to 0.43.0 Signed-off-by: sharathsivakumar <mailssr9@gmail.com>
…lptracegrpc 1.16.0 to 1.17.0 Signed-off-by: sharathsivakumar <mailssr9@gmail.com>
Best to rebase, then add in your dependency commits last. |
Cool. let me do that then. |
Done in #16552 |
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.