-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: enable markdown_marker checker #16708
Conversation
d3c4571
to
99a5492
Compare
Updated: @crawford has accepted that patch. Waiting for new release of marker and then mark this as reviewable. |
Signed-off-by: Wei Fu <fuweid89@gmail.com>
99a5492
to
81fe610
Compare
@crawford thank you! Verified it and it's working. REF: https://github.com/etcd-io/etcd/actions/runs/6504599480/job/17666787379?pr=16708 PASSES="markdown_marker" ./scripts/test.sh
Running with --race
Starting at: Fri Oct 13 06:04:06 UTC 2023
'markdown_marker' started at Fri Oct 13 06:04:06 UTC 2023
% 'marker' '--skip-http' '--allow-absolute-paths' '--root' '/home/runner/work/etcd/etcd' '-e' './CHANGELOG' '-e' './etcdctl' '-e' 'etcdutl' '-e' './tools'
'markdown_marker' PASSED and completed at Fri Oct 13 06:04:06 UTC 2023
SUCCESS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a comment/question #16708 (comment)
One problem this PR surfaces is the increased number of validators that are not available locally. Could we consider adding more installation script in the Makefile? |
Yes. Sorry I didn't mention it. I do have plan to handle this in the follow-up. |
Thanks for already thinking about this. Let's not block on this then. |
Part of #15549
It's trying to re-enable the markdown_marker checker in the repo because we have the old issue #7123.
However, the marker tool doesn't support the github-like relative path render.
The
/absolute-path
is useful and easier to be maintained in the github repo than../../
.Filed to crawford/marker#23 and hope @crawford can give some inputs.
CI Result: https://github.com/etcd-io/etcd/actions/runs/6446242086/job/17501156794?pr=16708#step:9:459
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.