Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace the deprecated x509.ParseCRL with x509.ParseRevocationList #17106

Merged
merged 2 commits into from
Dec 29, 2023
Merged

Replace the deprecated x509.ParseCRL with x509.ParseRevocationList #17106

merged 2 commits into from
Dec 29, 2023

Conversation

ivanvc
Copy link
Member

@ivanvc ivanvc commented Dec 13, 2023

Continues the work from #16860. Implements the unit tests to verify the revocation list functionality.

Fixes #16861.

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

@ahrtr @ivanvc
replace the deprecated x509.ParseCRL with x509.ParseRevocationList
16d1ef9 
Signed-off-by: Benjamin Wang <wachao@vmware.com>
@k8s-ci-robot
Copy link

Hi @ivanvc. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ivanvc
Copy link
Member Author

ivanvc commented Dec 13, 2023

Can you re-run the failed workflows? After reviewing the errors, I think they're not related to my changes.

@jmhbnz
Copy link
Member

jmhbnz commented Dec 13, 2023

/retest

ahrtr
ahrtr reviewed Dec 15, 2023
View reviewed changes
client/pkg/transport/listener_test.go Outdated Show resolved Hide resolved
client/pkg/transport/listener_test.go Outdated Show resolved Hide resolved
@ivanvc ivanvc force-pushed the cert_20231103 branch 2 times, most recently from 15d9a06 to 1a6f87e Compare December 20, 2023 04:09
@ivanvc
Copy link
Member Author

ivanvc commented Dec 20, 2023 •
edited
Loading

/retest

ahrtr
ahrtr reviewed Dec 20, 2023
View reviewed changes
client/pkg/transport/listener_test.go Outdated Show resolved Hide resolved
client/pkg/transport/listener_test.go Outdated Show resolved Hide resolved
@ivanvc
Copy link
Member Author

ivanvc commented Dec 21, 2023

Thanks for the feedback so far @ahrtr 🙇. It's my first time doing a code-related PR in the repo. I appreciate your guidance.

@ivanvc
Copy link
Member Author

ivanvc commented Dec 21, 2023

/test pull-etcd-unit-test

ahrtr
ahrtr reviewed Dec 21, 2023
View reviewed changes
client/pkg/transport/listener_test.go Show resolved Hide resolved
client/pkg/transport/listener_test.go Outdated Show resolved Hide resolved
client/pkg/transport/listener_test.go Outdated Show resolved Hide resolved
client/pkg/transport/listener_test.go Outdated Show resolved Hide resolved
@ivanvc ivanvc requested a review from ahrtr December 21, 2023 18:29
@ivanvc
Copy link
Member Author

ivanvc commented Dec 21, 2023

/retest

ahrtr
ahrtr approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with two minor comments.

Thank you!

client/pkg/transport/listener_test.go Outdated Show resolved Hide resolved
client/pkg/transport/listener_test.go Outdated Show resolved Hide resolved
@ivanvc
Copy link
Member Author

ivanvc commented Dec 21, 2023

/retest

@ivanvc
client: implement TLS CRL tests
e9434c9 
Signed-off-by: Ivan Valdes <ivan@vald.es>
@ahrtr
Copy link
Member

ahrtr commented Dec 29, 2023

cc @fuweid @jmhbnz @serathius

jmhbnz
jmhbnz approved these changes Dec 29, 2023
View reviewed changes
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @ivanvc and @ahrtr

@ahrtr ahrtr merged commit f8d5ba9 into etcd-io:main Dec 29, 2023
39 checks passed
@jmhbnz jmhbnz mentioned this pull request Dec 31, 2023
Closed
@ivanvc ivanvc deleted the cert_20231103 branch February 1, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahrtr ahrtr ahrtr approved these changes

@jmhbnz jmhbnz jmhbnz approved these changes

Assignees
No one assigned
Labels
ok-to-test
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace the deprecated x509.ParseCRL with x509.ParseRevocationList
4 participants
@ivanvc @k8s-ci-robot @jmhbnz @ahrtr