Enable org members to approve workflows for backports #17193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Blair <mail@jamesblair.net>
serathius
approved these changes
Jan 3, 2024
|
/retest |
|
cc @ahrtr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier today I
/ok-to-testapproved #17190 and #17189.These are both backport prs to our stable release branches.
After adding the comment k8s ci bot happily added the correct
ok-to-testlabel, however our github workflows didn't actually approve and run, meaning they are still waiting on a maintainer.Investigating it looks like we are just missing
release-3.4andrelease-3.5branches in thegh-workflow-approve.yamlworkflow to fix this so org members can help take the load off maintainers when managing backports.