Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.5] Fix delete inconsistencies in read buffer #17230

Merged
merged 2 commits into from
Jan 12, 2024
Merged

[3.5] Fix delete inconsistencies in read buffer #17230

merged 2 commits into from
Jan 12, 2024

Conversation

siyuanfoundation
Copy link
Contributor

@siyuanfoundation siyuanfoundation commented Jan 11, 2024 •
edited
Loading

@siyuanfoundation
add tests to test tx delete consistency.
f219ab4 
Signed-off-by: Siyuan Zhang <sizhang@google.com>
@siyuanfoundation
commit bbolt transaction if there is any pending deleting operations
2d531a3 
Signed-off-by: Siyuan Zhang <sizhang@google.com>
@siyuanfoundation
Copy link
Contributor Author

/retest

fuweid
fuweid approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@siyuanfoundation
Copy link
Contributor Author

cc @ahrtr

ahrtr
ahrtr approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

thanks

@ahrtr ahrtr merged commit 0c302d4 into etcd-io:release-3.5 Jan 12, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serathius serathius serathius approved these changes

@fuweid fuweid fuweid approved these changes

@ahrtr ahrtr ahrtr approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@siyuanfoundation @serathius @fuweid @ahrtr