Add explicit checks for assumptions in robustness test validation #17759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serathius
force-pushed
the
robustness-assumptions
branch
4 times, most recently
from
a2ecd1b
to
93f9cb2
Compare
|
/retest |
ahrtr
reviewed
Apr 12, 2024
serathius
force-pushed
the
robustness-assumptions
branch
4 times, most recently
from
3c071e4
to
f54fbc8
Compare
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
serathius
force-pushed
the
robustness-assumptions
branch
from
f54fbc8
to
f8de338
Compare
ahrtr
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @MadhavJivrajani @ahrtr @siyuanfoundation
Started using #17733 and imminently make a mistake of copying one report over another. This results in strange errors and linearization visualization. It took me more time than I want to admit to identify the problem.
Adding validation of assumptions that should always be true if report comes directly from robustness test run. This should re-evaluation of reports more user friendly by providing clear errors.