Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcdserver: updated pre-vote flag description #17762

Merged
merged 1 commit into from
Apr 13, 2024

Conversation

Fube
Copy link
Contributor

@Fube Fube commented Apr 9, 2024

@k8s-ci-robot
Copy link

Hi @Fube. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jmhbnz
Copy link
Member

jmhbnz commented Apr 9, 2024

/ok-to-test

server/embed/config.go Outdated Show resolved Hide resolved
server/embed/config.go Outdated Show resolved Hide resolved
@jmhbnz
Copy link
Member

jmhbnz commented Apr 11, 2024

Note that once this merges we need to raise a similar pr to update the flag description on the website: https://github.com/etcd-io/website/blob/main/content/en/docs/v3.6/op-guide/configuration.md

https://etcd.io/docs/v3.6/op-guide/configuration.

@Fube
Copy link
Contributor Author

Fube commented Apr 11, 2024

Note that once this merges we need to raise a similar pr to update the flag description on the website: https://github.com/etcd-io/website/blob/main/content/en/docs/v3.6/op-guide/configuration.md

https://etcd.io/docs/v3.6/op-guide/configuration.

On the subject of the website, I could not find anything on Raft itself.

Since this flag and a couple of others say "enables XYZ in Raft", maybe it'd be good to have a dedicated section on the "Learning" page: https://etcd.io/docs/v3.6/learning/

@ahrtr
Copy link
Member

ahrtr commented Apr 11, 2024

maybe it'd be good to have a dedicated section on the "Learning" page: https://etcd.io/docs/v3.6/learning/

I think users should really read https://pkg.go.dev/go.etcd.io/raft/v3#Config, or even raft paper.

@Fube
Copy link
Contributor Author

Fube commented Apr 11, 2024

maybe it'd be good to have a dedicated section on the "Learning" page: https://etcd.io/docs/v3.6/learning/

I think users should really read https://pkg.go.dev/go.etcd.io/raft/v3#Config, or even raft paper.

Apologies I was unclear, I meant more like link to the Raft GitHub page on the learning page of the website.

Or do you believe that is outside of the scope of the website?

@ahrtr
Copy link
Member

ahrtr commented Apr 11, 2024

Apologies I was unclear, I meant more like link to the Raft GitHub page on the learning page of the website.

Or do you believe that is outside of the scope of the website?

Thanks for the suggestion. I think it's indeed outside of the scope of etcd's doc. But I don't have very strong opinion on this.

To better communicate what the pre-vote phase in Raft is.

Signed-off-by: Fube <fubeitch@gmail.com>
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green - Thanks @Fube

@serathius
Copy link
Member

/retest

@ahrtr ahrtr merged commit 9420f27 into etcd-io:main Apr 13, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Document pre-vote flag
5 participants