-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
etcdserver: updated pre-vote flag description #17762
Conversation
Hi @Fube. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
4888ff9
to
c9f3647
Compare
Note that once this merges we need to raise a similar pr to update the flag description on the website: https://github.com/etcd-io/website/blob/main/content/en/docs/v3.6/op-guide/configuration.md |
On the subject of the website, I could not find anything on Raft itself. Since this flag and a couple of others say "enables XYZ in Raft", maybe it'd be good to have a dedicated section on the "Learning" page: https://etcd.io/docs/v3.6/learning/ |
I think users should really read https://pkg.go.dev/go.etcd.io/raft/v3#Config, or even raft paper. |
Apologies I was unclear, I meant more like link to the Raft GitHub page on the learning page of the website. Or do you believe that is outside of the scope of the website? |
Thanks for the suggestion. I think it's indeed outside of the scope of etcd's doc. But I don't have very strong opinion on this. |
To better communicate what the pre-vote phase in Raft is. Signed-off-by: Fube <fubeitch@gmail.com>
c9f3647
to
cf66d0f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on green - Thanks @Fube
/retest |
Closes #17328
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.