Add run-govulncheck Makefile target #18182
Conversation
Add a `Makefile` target to run govuln across the submodules. So, it can be imported into a prow job. Signed-off-by: Ivan Valdes <ivan@vald.es>
| @@ -164,6 +164,13 @@ ifeq (, $(shell which yamlfmt)) | |||
| endif | |||
| yamlfmt -conf tools/.yamlfmt . | |||
|
|
|||
| .PHONY: run-govulncheck | |||
| run-govulncheck: | |||
There was a problem hiding this comment.
I'm not 100% convinced of this name. Suggestions are welcome.
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files
... and 21 files with indirect coverage changes @@ Coverage Diff @@
## main #18182 +/- ##
==========================================
+ Coverage 68.82% 68.88% +0.06%
==========================================
Files 416 416
Lines 35128 35151 +23
==========================================
+ Hits 24177 24215 +38
+ Misses 9549 9530 -19
- Partials 1402 1406 +4 Continue to review full report in Codecov by Sentry.
|
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
It seems like Robustness tests are consistently failing on the prow infra 🤕 https://prow.k8s.io/job-history/gs/kubernetes-jenkins/pr-logs/directory/pull-etcd-robustness-amd64 |
Issue appears to be permissions for accessing the fuse device required for lazyfs robustness scenarios. I'll raise a pr to fix. Edit: Opened kubernetes/test-infra#32769 |
|
/retest |
There was a problem hiding this comment.
Per module scan looks to be working nicely https://github.com/etcd-io/etcd/actions/runs/9531416934/job/26272339407?pr=18182
LGTM - Thanks @ivanvc
Add a
Makefiletarget to run govuln across the submodules. This will allow it to be imported into a prow job and remove the logic from the GitHub workflow file.Part of #18173.
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.