Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add changelog for bugfix 18164 prometheus metric register of walWriteSec #18218

Conversation

andyxning
Copy link
Contributor

@k8s-ci-robot
Copy link

Hi @andyxning. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andyxning - Just need to update the link then looks good to me.

CHANGELOG/CHANGELOG-3.5.md Outdated Show resolved Hide resolved
@jmhbnz
Copy link
Member

jmhbnz commented Jun 24, 2024

/ok-to-test

@andyxning andyxning force-pushed the changelog_for_bugfix_18164_prometheus_metric_register_of_walWriteSec branch from 012d860 to 37fe67b Compare June 24, 2024 03:06
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @andyxning

@k8s-ci-robot
Copy link

@andyxning: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-robustness-amd64 37fe67b link false /test pull-etcd-robustness-amd64

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ahrtr
Copy link
Member

ahrtr commented Jun 24, 2024

/test pull-etcd-robustness-amd64

@ahrtr ahrtr merged commit 67a6dbd into etcd-io:main Jun 24, 2024
47 of 48 checks passed
@andyxning andyxning deleted the changelog_for_bugfix_18164_prometheus_metric_register_of_walWriteSec branch June 24, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants