Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.5] client/v3/watch.go: use fmt go pkg for gRPC metadata map printing #18312

Merged

Conversation

mohamedawnallah
Copy link
Contributor

Description

This PR backports the changes from #18308 PR to the release-3.5 branch.

Issue

Addresses Issue #18303 in the backport release-3.5.

@k8s-ci-robot
Copy link

Hi @mohamedawnallah. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: Mohamed Awnallah <mohamedmohey2352@gmail.com>
Signed-off-by: Mohamed Awnallah <mohamedmohey2352@gmail.com>
Co-authored-by: Benjamin Wang <ahrtr>
@ivanvc
Copy link
Member

ivanvc commented Jul 12, 2024

/retitle [3.5] client/v3/watch.go: use fmt go pkg for gRPC metadata map printing

@k8s-ci-robot k8s-ci-robot changed the title client/v3/watch.go: use fmt go pkg for gRPC metadata map printing (backport release-3.5) [3.5] client/v3/watch.go: use fmt go pkg for gRPC metadata map printing Jul 12, 2024
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks

@ivanvc
Copy link
Member

ivanvc commented Jul 12, 2024

/ok-to-test

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @mohamedawnallah

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @mohamedawnallah.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ahrtr, ivanvc, jmhbnz, mohamedawnallah

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 4548f41 into etcd-io:release-3.5 Jul 13, 2024
27 checks passed
mohamedawnallah added a commit to mohamedawnallah/etcd that referenced this pull request Jul 13, 2024
In this commit, we update the changelog for gRPC
metadata printing in release 3.5 which is mainly
a backport from PR etcd-io#18312.

Signed-off-by: Mohamed Awnallah <mohamedmohey2352@gmail.com>
mohamedawnallah added a commit to mohamedawnallah/etcd that referenced this pull request Jul 13, 2024
In this commit, we update the changelog for gRPC
metadata printing in release 3.5 which is mainly
a backport from PR etcd-io#18312.

Signed-off-by: Mohamed Awnallah <mohamedmohey2352@gmail.com>
mohamedawnallah added a commit to mohamedawnallah/etcd that referenced this pull request Jul 13, 2024
In this commit, we update the changelog for gRPC
metadata printing in release 3.5 which is mainly
a backport from PR etcd-io#18312.

Signed-off-by: Mohamed Awnallah <mohamedmohey2352@gmail.com>
mohamedawnallah added a commit to mohamedawnallah/etcd that referenced this pull request Jul 14, 2024
In this commit, we update the changelog for gRPC
metadata printing in release 3.5 which is mainly
a backport from PR etcd-io#18312.

Signed-off-by: Mohamed Awnallah <mohamedmohey2352@gmail.com>
mohamedawnallah added a commit to mohamedawnallah/etcd that referenced this pull request Jul 14, 2024
In this commit, we update the changelog for gRPC
metadata printing in release 3.5 which is mainly
a backport from PR etcd-io#18312.

Signed-off-by: Mohamed Awnallah <mohamedmohey2352@gmail.com>
@ivanvc ivanvc mentioned this pull request Jul 15, 2024
4 tasks
ah8ad3 pushed a commit to ah8ad3/etcd that referenced this pull request Jul 23, 2024
In this commit, we update the changelog for gRPC
metadata printing in release 3.5 which is mainly
a backport from PR etcd-io#18312.

Signed-off-by: Mohamed Awnallah <mohamedmohey2352@gmail.com>
aneesh1 pushed a commit to DataDog/etcd that referenced this pull request Sep 24, 2024
…tgRPCMetadata

[3.5] client/v3/watch.go: use fmt go pkg for gRPC metadata map printing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants