Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.4] Remove gsutil acl command for bucket permissions #18345

Merged
merged 1 commit into from
Jul 20, 2024

Conversation

jmhbnz
Copy link
Member

@jmhbnz jmhbnz commented Jul 19, 2024

With verification completed during release v3.5.15 we are certain this improvement is safe so we should now also backport f0246a9 to release-3.4.

The bucket is already fully public so new releases don't need to run this command.

This will prevent significant terminal spam during the release process as there are thousands of objects in the bucket.

The bucket is already fully public so new releases don't need to run this command.

This will prevent significant terminal spam during the release process as there are thousands of objects in the bucket.

Backports etcd-io@f0246a9

Signed-off-by: James Blair <mail@jamesblair.net>
@jmhbnz jmhbnz changed the title Remove gsutil acl command for bucket permissions [3.4] Remove gsutil acl command for bucket permissions Jul 19, 2024
@jmhbnz
Copy link
Member Author

jmhbnz commented Jul 19, 2024

cc @ahrtr, @ivanvc

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @jmhbnz.

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ahrtr, ivanvc, jmhbnz
Once this PR has been reviewed and has the lgtm label, please assign fanminshi for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jmhbnz jmhbnz merged commit 8bd8d2b into etcd-io:release-3.4 Jul 20, 2024
18 checks passed
@ivanvc ivanvc mentioned this pull request Aug 22, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

4 participants