Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a go workspace #18414

Closed
wants to merge 29 commits into from
Closed

Use a go workspace #18414

wants to merge 29 commits into from

Conversation

ivanvc
Copy link
Member

@ivanvc ivanvc commented Aug 7, 2024

WIP #18409

TODO:

  • verify-gofmt
  • verify-bom
  • verify-lint
  • verify-dep
  • verify-goword
  • verify-govet
  • verify-license-header
  • verify-receiver-name
  • verify-mod-tidy
  • verify-shellws
  • verify-proto-annotations
  • verify-genproto
  • verify-yamllint
  • verify-govet-shadow
  • verify-markdown-marker
  • verify-go-versions
  • import-boss without k8s dependency?
  • scripts/fix.sh leaves the repo dirty (go.work.sum)

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ivanvc
Once this PR has been reviewed and has the lgtm label, please assign jmhbnz for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ivanvc
Copy link
Member Author

ivanvc commented Aug 7, 2024

/test all

@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.80%. Comparing base (df4e472) to head (54d6674).
Report is 2 commits behind head on main.

Current head 54d6674 differs from pull request most recent head 0cd6df5

Please upload reports for the commit 0cd6df5 to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

see 19 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18414      +/-   ##
==========================================
- Coverage   68.83%   68.80%   -0.03%     
==========================================
  Files         420      420              
  Lines       35475    35475              
==========================================
- Hits        24420    24410      -10     
- Misses       9631     9633       +2     
- Partials     1424     1432       +8     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df4e472...0cd6df5. Read the comment docs.

@ivanvc
Copy link
Member Author

ivanvc commented Aug 8, 2024

/test pull-etcd-verify

1 similar comment
@ivanvc
Copy link
Member Author

ivanvc commented Aug 8, 2024

/test pull-etcd-verify

@ivanvc
Copy link
Member Author

ivanvc commented Aug 9, 2024

/test pull-etcd-verify

ivanvc and others added 15 commits August 9, 2024 10:43
Signed-off-by: Ivan Valdes <ivan@vald.es>
Signed-off-by: Ivan Valdes <ivan@vald.es>
Signed-off-by: Ivan Valdes <ivan@vald.es>
Signed-off-by: Ivan Valdes <ivan@vald.es>
Signed-off-by: Ivan Valdes <ivan@vald.es>
Signed-off-by: Ivan Valdes <ivan@vald.es>
Signed-off-by: Ivan Valdes <ivan@vald.es>
Signed-off-by: Ivan Valdes <ivan@vald.es>
Signed-off-by: Ivan Valdes <ivan@vald.es>
Signed-off-by: Ivan Valdes <ivan@vald.es>
Signed-off-by: Ivan Valdes <ivan@vald.es>
Signed-off-by: Ivan Valdes <ivan@vald.es>
Signed-off-by: Ivan Valdes <ivan@vald.es>
Signed-off-by: Ivan Valdes <ivan@vald.es>
Signed-off-by: Ivan Valdes <ivan@vald.es>
Signed-off-by: Ivan Valdes <ivan@vald.es>
Signed-off-by: Ivan Valdes <ivan@vald.es>
@ivanvc
Copy link
Member Author

ivanvc commented Aug 9, 2024

/test pull-etcd-verify

Signed-off-by: Ivan Valdes <ivan@vald.es>
Signed-off-by: Ivan Valdes <ivan@vald.es>
Signed-off-by: Ivan Valdes <ivan@vald.es>
Signed-off-by: Ivan Valdes <ivan@vald.es>
Signed-off-by: Ivan Valdes <ivan@vald.es>
Signed-off-by: Ivan Valdes <ivan@vald.es>
@ivanvc
Copy link
Member Author

ivanvc commented Aug 9, 2024

/test pull-etcd-verify

1 similar comment
@ivanvc
Copy link
Member Author

ivanvc commented Aug 9, 2024

/test pull-etcd-verify

Signed-off-by: Ivan Valdes <ivan@vald.es>
@ivanvc
Copy link
Member Author

ivanvc commented Aug 9, 2024

/test pull-etcd-verify

Signed-off-by: Ivan Valdes <ivan@vald.es>
@ivanvc
Copy link
Member Author

ivanvc commented Aug 10, 2024

/test pull-etcd-verify

Signed-off-by: Ivan Valdes <ivan@vald.es>
@ivanvc
Copy link
Member Author

ivanvc commented Aug 10, 2024

/test pull-etcd-verify

Signed-off-by: Ivan Valdes <ivan@vald.es>
Signed-off-by: Ivan Valdes <ivan@vald.es>
@ivanvc
Copy link
Member Author

ivanvc commented Aug 10, 2024

/test pull-etcd-verify

Signed-off-by: Ivan Valdes <ivan@vald.es>
@ivanvc
Copy link
Member Author

ivanvc commented Aug 10, 2024

/test pull-etcd-verify

@k8s-ci-robot
Copy link

@ivanvc: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-integration-1-cpu-amd64 f2c30d8 link true /test pull-etcd-integration-1-cpu-amd64
pull-etcd-verify 0cd6df5 link true /test pull-etcd-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ivanvc ivanvc closed this Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants