-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce number of concurrent clients to 8 and compactions to avoid flakes #18442
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: serathius The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
86a49d9
to
824740f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted filessee 25 files with indirect coverage changes @@ Coverage Diff @@
## main #18442 +/- ##
==========================================
- Coverage 68.81% 68.79% -0.02%
==========================================
Files 420 420
Lines 35490 35490
==========================================
- Hits 24422 24417 -5
- Misses 9637 9643 +6
+ Partials 1431 1430 -1 Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks Marek.
@ah8ad3: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Not hitting minimal QPS is expected to be caused by introduction of compation. Let's avoid it for high throughput test cases. Reducing number of clients to avoid linearization timeouts. Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
824740f
to
f194f47
Compare
Not hitting minimal QPS is expected to be caused by introduction of
compation. Let's avoid it for high throughput test cases.
Reducing number of clients to avoid linearization timeouts.
cc @ah8ad3 @fuweid @MadhavJivrajani @siyuanfoundation