-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: remaining errors.Is conversions #18634
base: main
Are you sure you want to change the base?
tests: remaining errors.Is conversions #18634
Conversation
Hi @redwrasse. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted filessee 20 files with indirect coverage changes @@ Coverage Diff @@
## main #18634 +/- ##
==========================================
- Coverage 68.79% 68.75% -0.05%
==========================================
Files 420 420
Lines 35493 35492 -1
==========================================
- Hits 24419 24403 -16
- Misses 9648 9660 +12
- Partials 1426 1429 +3 Continue to review full report in Codecov by Sentry.
|
Hi @redwrasse, thanks for opening this pull request. I know this is a draft, but I see the following instances that need to be updated:
|
Added those is @ivanvc . Let me know if you see anymore, otherwise I'll mark this ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to address nil error before calling errors.Is()
By the way, have you considered activate errorlint with golangci, that can be very helpful.
You can see how I did that on prometheus if you need an idea on how to split the work
Thanks for the suggestions, @mmorel-35. I was looking for a linter rule but couldn't find one (refer to: #18510 (comment)). We're tracking the work in the parent task #18576. Given the changes you suggested, it may be a good idea to revise the merged PRs. @redwrasse, are you okay with opening this to more contributors? @mmorel-35, would you be interested in working on this, too? |
@ivanvc and @mmorel-35 - definitely open to more contributors! Let me know how you'd like to proceed. |
I believe it can be splitted per module. |
Thank you so much, @mmorel-35 🙇 🌟 |
/test all |
Hi @redwrasse, I enabled Thanks again for your help! Edit: If you mark it as ready for review, can you rebase it? The checks that failed should be working on the main branch now. Thanks. |
@ivanvc apologies, I completely forgot about/lost track of this PR. Yes, let me rebase and open for review, and the remaining issues can be a separate PR. |
26d26d0
to
221225e
Compare
Signed-off-by: redwrasse <mail@redwrasse.io>
221225e
to
1c825ad
Compare
Rebased, squashed, opened for review. Hopefully this one is good to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, Samir.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ivanvc, mmorel-35, redwrasse The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tests directory errors.Is conversions, as part of #18576