Documentation/op-guide: clarify security.md on TLS auth #9140
+5
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it more accurate (just as pkg/transport/listener_tls.go does). Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
fanminshi
reviewed
Jan 12, 2018
| "hosts": [ | ||
| "b.com" | ||
| ], | ||
| ... | ||
| } | ||
| ``` | ||
|
|
||
| when peer B's remote IP address is `10.138.0.2`. When peer B tries to join the cluster, peer A looks up the incoming host `b.com` to get the list of IP addresses (e.g. `dig b.com`). And rejects B if the list does not contain the IP `10.138.0.2`, with the error `tls: 10.138.0.2 does not match any of DNSNames ["b.com"]`. |
There was a problem hiding this comment.
do you know why the diff show up as red?
There was a problem hiding this comment.
Seems like github markdown issue. If you look at the file with view button, it looks correct :0
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it more accurate (just as pkg/transport/listener_tls.go does).