Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix govet #9228

Merged
merged 8 commits into from
Jan 25, 2018
Merged

Fix govet #9228

merged 8 commits into from
Jan 25, 2018

Conversation

mkumatag
Copy link
Contributor

Fixes: #9225

@mkumatag
Copy link
Contributor Author

/cc @gyuho

@codecov-io
Copy link

codecov-io commented Jan 25, 2018

Codecov Report

Merging #9228 into master will increase coverage by 0.01%.
The diff coverage is 53.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9228      +/-   ##
==========================================
+ Coverage   75.87%   75.88%   +0.01%     
==========================================
  Files         363      363              
  Lines       30161    30161              
==========================================
+ Hits        22884    22889       +5     
+ Misses       5670     5665       -5     
  Partials     1607     1607
Impacted Files Coverage Δ
clientv3/leasing/txn.go 91.26% <100%> (ø) ⬆️
clientv3/leasing/cache.go 88.88% <100%> (+1.66%) ⬆️
etcdctl/ctlv3/command/move_leader_command.go 68.29% <33.33%> (ø) ⬆️
lease/leasehttp/http.go 63.97% <57.14%> (-1.48%) ⬇️
etcdserver/api/v3rpc/lease.go 78.37% <0%> (-8.11%) ⬇️
clientv3/namespace/watch.go 93.93% <0%> (-6.07%) ⬇️
etcdctl/ctlv3/command/lease_command.go 65.34% <0%> (-5.95%) ⬇️
pkg/testutil/recorder.go 77.77% <0%> (-3.71%) ⬇️
etcdserver/api/v3rpc/watch.go 82.4% <0%> (-3.01%) ⬇️
etcdserver/api/v3election/election.go 64.7% <0%> (-2.95%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37f577c...c27998d. Read the comment docs.

@mkumatag
Copy link
Contributor Author

gotip job passed: https://travis-ci.org/coreos/etcd/jobs/333191204

Copy link
Contributor

@gyuho gyuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks!

@gyuho gyuho merged commit 8ee3f5a into etcd-io:master Jan 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants