Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: support journald with structured logging zap, rename to "--log-outputs" #9624

Merged
merged 22 commits into from
Apr 25, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
fcbb303
pkg/logutil: add "NewJournaldWriter"
gyuho Apr 24, 2018
1fa80bf
pkg/logutil: add "NewGRPCLoggerV2FromZapCore"
gyuho Apr 24, 2018
48d5542
embed: set journald logging with zap
gyuho Apr 24, 2018
6df3179
pkg/logutil: add "NewRaftLoggerFromZapCore"
gyuho Apr 24, 2018
69c51e2
embed: change "loggerConfig" to "*zap.Config"
gyuho Apr 24, 2018
a34dd27
pkg/logutil: change "NewRaftLogger" function signature
gyuho Apr 24, 2018
d33a74d
embed: add "loggerCore" field for Raft logger
gyuho Apr 24, 2018
3ea7a5d
etcdserver: add "LoggerCore" field for Raft logger
gyuho Apr 24, 2018
f99cb35
embed: rename "LogOutput" to "LogOutputs"
gyuho Apr 25, 2018
d4987f4
CHANGELOG: track logger changes
gyuho Apr 25, 2018
53c5cd5
Documentation/upgrades: highlight "embed.Config.LogOutputs" change
gyuho Apr 25, 2018
a113d6c
functional/rpcpb: change to LogOutputs
gyuho Apr 25, 2018
0e4c94c
CHANGELOG: highlight "--log-outputs" flag
gyuho Apr 25, 2018
22609a6
Documentation/upgrades: highlight "--log-outputs"
gyuho Apr 25, 2018
1539fdd
etcd.conf.yml.sample: rename to "log-outputs"
gyuho Apr 25, 2018
af5bc43
embed,etcdmain: rename to "--log-outputs" flag
gyuho Apr 25, 2018
a6c30ea
functional: rename to "log-outputs"
gyuho Apr 25, 2018
58a6034
*: rename to "--log-outputs" in docs
gyuho Apr 25, 2018
b748abc
*: change typo in "auto-compaction-retention" field
gyuho Apr 25, 2018
88c70d0
embed,integration,snapshot: use "LogOutputs"
gyuho Apr 25, 2018
9cd9ae2
pkg/logutil: do not build journald logger on windows
gyuho Apr 25, 2018
154e2ac
embed: do not import journald dependencies on windows
gyuho Apr 25, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion CHANGELOG-3.1.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@


## [v3.1.14](https://github.com/coreos/etcd/releases/tag/v3.1.14) (2018-04-24)

See [code changes](https://github.com/coreos/etcd/compare/v3.1.13...v3.1.14) and [v3.1 upgrade guide](https://github.com/coreos/etcd/blob/master/Documentation/upgrades/upgrade_3_1.md) for any breaking changes.
Expand All @@ -6,7 +8,7 @@ See [code changes](https://github.com/coreos/etcd/compare/v3.1.13...v3.1.14) and

- Add [`etcd_server_is_leader`](https://github.com/coreos/etcd/pull/9587) Prometheus metric.

### Added: `etcd`
### `etcd`

- Add [`--initial-election-tick-advance`](https://github.com/coreos/etcd/pull/9591) flag to configure initial election tick fast-forward.
- By default, `--initial-election-tick-advance=true`, then local member fast-forwards election ticks to speed up "initial" leader election trigger.
Expand All @@ -18,6 +20,10 @@ See [code changes](https://github.com/coreos/etcd/compare/v3.1.13...v3.1.14) and
- If single-node, it advances ticks regardless.
- Address [disruptive rejoining follower node](https://github.com/coreos/etcd/issues/9333).

### Go

- Compile with [*Go 1.8.7*](https://golang.org/doc/devel/release.html#go1.8).


## [v3.1.13](https://github.com/coreos/etcd/releases/tag/v3.1.13) (2018-03-29)

Expand Down
20 changes: 12 additions & 8 deletions CHANGELOG-3.2.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ See [code changes](https://github.com/coreos/etcd/compare/v3.2.18...v3.2.19) and
- However, a certificate whose SAN field does [not include any domain names but only IP addresses](https://github.com/coreos/etcd/issues/9541) would request `*tls.ClientHelloInfo` with an empty `ServerName` field, thus failing to trigger the TLS reload on initial TLS handshake; this becomes a problem when expired certificates need to be replaced online.
- Now, `(*tls.Config).Certificates` is created empty on initial TLS client handshake, first to trigger `(*tls.Config).GetCertificate`, and then to populate rest of the certificates on every new TLS connection, even when client SNI is empty (e.g. cert only includes IPs).

### Added: `etcd`
### `etcd`

- Add [`--initial-election-tick-advance`](https://github.com/coreos/etcd/pull/9591) flag to configure initial election tick fast-forward.
- By default, `--initial-election-tick-advance=true`, then local member fast-forwards election ticks to speed up "initial" leader election trigger.
Expand All @@ -29,6 +29,10 @@ See [code changes](https://github.com/coreos/etcd/compare/v3.2.18...v3.2.19) and
- If single-node, it advances ticks regardless.
- Address [disruptive rejoining follower node](https://github.com/coreos/etcd/issues/9333).

### Go

- Compile with [*Go 1.8.7*](https://golang.org/doc/devel/release.html#go1.8).


## [v3.2.18](https://github.com/coreos/etcd/releases/tag/v3.2.18) (2018-03-29)

Expand Down Expand Up @@ -149,7 +153,7 @@ See [code changes](https://github.com/coreos/etcd/compare/v3.2.11...v3.2.12) and

- Fix [error message of `Revision` compactor](https://github.com/coreos/etcd/pull/8999) in server-side.

### Added: `clientv3`
### `clientv3`

- Add [`MaxCallSendMsgSize` and `MaxCallRecvMsgSize`](https://github.com/coreos/etcd/pull/9047) fields to [`clientv3.Config`](https://godoc.org/github.com/coreos/etcd/clientv3#Config).
- Fix [exceeded response size limit error in client-side](https://github.com/coreos/etcd/issues/9043).
Expand Down Expand Up @@ -295,7 +299,7 @@ See [code changes](https://github.com/coreos/etcd/compare/v3.2.5...v3.2.6) and [

See [code changes](https://github.com/coreos/etcd/compare/v3.2.4...v3.2.5) and [v3.2 upgrade guide](https://github.com/coreos/etcd/blob/master/Documentation/upgrades/upgrade_3_2.md) for any breaking changes.

### Added: v3 `etcdctl`
### v3 `etcdctl`

- Return non-zero exit code on unhealthy `endpoint health`.

Expand Down Expand Up @@ -453,7 +457,7 @@ See [security doc](https://github.com/coreos/etcd/blob/master/Documentation/op-g
- Logging, monitoring
- Server warns large snapshot operations.

### Added: `etcd`
### `etcd`

- Add `--enable-v2` flag to enable v2 API server.
- `--enable-v2=true` by default.
Expand All @@ -468,14 +472,14 @@ See [security doc](https://github.com/coreos/etcd/blob/master/Documentation/op-g
- If compaction succeeds or requested revision has already been compacted, it resets period timer and removes used compacted revision from historical revision records (e.g. start next revision collect and compaction from previously collected revisions).
- If compaction fails, it retries in 5 minutes.

### Added: `clientv3`
### `clientv3`

- STM prefetching.
- Add namespace feature.
- Add `ErrOldCluster` with server version checking.
- Translate `WithPrefix()` into `WithFromKey()` for empty key.

### Added: v3 `etcdctl`
### v3 `etcdctl`

- Add `check perf` command.
- Add `--from-key` flag to role grant-permission command.
Expand All @@ -485,13 +489,13 @@ See [security doc](https://github.com/coreos/etcd/blob/master/Documentation/op-g

- Allow snapshot over 512MB.

### Added: `grpc-proxy`
### `grpc-proxy`

- Proxy endpoint discovery.
- Namespaces.
- Coalesce lease requests.

### Added: `gateway`
### `gateway`

- Support [DNS SRV priority](https://github.com/coreos/etcd/pull/7882) for [smart proxy routing](https://github.com/coreos/etcd/issues/4378).

Expand Down
22 changes: 11 additions & 11 deletions CHANGELOG-3.3.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ See [code changes](https://github.com/coreos/etcd/compare/v3.3.3...v3.3.4) and [
- However, a certificate whose SAN field does [not include any domain names but only IP addresses](https://github.com/coreos/etcd/issues/9541) would request `*tls.ClientHelloInfo` with an empty `ServerName` field, thus failing to trigger the TLS reload on initial TLS handshake; this becomes a problem when expired certificates need to be replaced online.
- Now, `(*tls.Config).Certificates` is created empty on initial TLS client handshake, first to trigger `(*tls.Config).GetCertificate`, and then to populate rest of the certificates on every new TLS connection, even when client SNI is empty (e.g. cert only includes IPs).

### Added: `etcd`
### `etcd`

- Add [`--initial-election-tick-advance`](https://github.com/coreos/etcd/pull/9591) flag to configure initial election tick fast-forward.
- By default, `--initial-election-tick-advance=true`, then local member fast-forwards election ticks to speed up "initial" leader election trigger.
Expand All @@ -29,7 +29,7 @@ See [code changes](https://github.com/coreos/etcd/compare/v3.3.3...v3.3.4) and [
- If single-node, it advances ticks regardless.
- Address [disruptive rejoining follower node](https://github.com/coreos/etcd/issues/9333).

### Added: `embed`
### Package `embed`

- Add [`embed.Config.InitialElectionTickAdvance`](https://github.com/coreos/etcd/pull/9591) to enable/disable initial election tick fast-forward.
- `embed.NewConfig()` would return `*embed.Config` with `InitialElectionTickAdvance` as true by default.
Expand Down Expand Up @@ -156,7 +156,7 @@ See [code changes](https://github.com/coreos/etcd/compare/v3.2.0...v3.3.0) and [
- To deprecate [`/v3alpha`](https://github.com/coreos/etcd/issues/8125) in v3.4.
- In v3.3, `curl -L http://localhost:2379/v3alpha/kv/put -X POST -d '{"key": "Zm9v", "value": "YmFy"}'` still works as a fallback to `curl -L http://localhost:2379/v3beta/kv/put -X POST -d '{"key": "Zm9v", "value": "YmFy"}'`, but `curl -L http://localhost:2379/v3alpha/kv/put -X POST -d '{"key": "Zm9v", "value": "YmFy"}'` won't work in v3.4. Use `curl -L http://localhost:2379/v3beta/kv/put -X POST -d '{"key": "Zm9v", "value": "YmFy"}'` instead.
- Change `--auto-compaction-retention` flag to [accept string values](https://github.com/coreos/etcd/pull/8563) with [finer granularity](https://github.com/coreos/etcd/issues/8503).
- Now that `--auto-compaction-retention` accepts string values, etcd configuration YAML file `log-output` field must be changed to `string` type.
- Now that `--auto-compaction-retention` accepts string values, etcd configuration YAML file `auto-compaction-retention` field must be changed to `string` type.
- Previously, `--config-file etcd.config.yaml` can have `auto-compaction-retention: 24` field, now must be `auto-compaction-retention: "24"` or `auto-compaction-retention: "24h"`.
- If configured as `--auto-compaction-mode periodic --auto-compaction-retention "24h"`, the time duration value for `--auto-compaction-retention` flag must be valid for [`time.ParseDuration`](https://golang.org/pkg/time/#ParseDuration) function in Go.

Expand Down Expand Up @@ -205,7 +205,7 @@ See [security doc](https://github.com/coreos/etcd/blob/master/Documentation/op-g
- Provide user's role on [auth permission error](https://github.com/coreos/etcd/pull/8164).
- Fix [auth store panic with disabled token](https://github.com/coreos/etcd/pull/8695).

### Added: `etcd`
### `etcd`

- Add [`--experimental-initial-corrupt-check`](https://github.com/coreos/etcd/pull/8554) flag to [check cluster database hashes before serving client/peer traffic](https://github.com/coreos/etcd/issues/8313).
- `--experimental-initial-corrupt-check=false` by default.
Expand All @@ -225,7 +225,7 @@ See [security doc](https://github.com/coreos/etcd/blob/master/Documentation/op-g
- Useful for [bypassing critical APIs when monitoring etcd](https://github.com/coreos/etcd/issues/8060).
- Add [`--auto-compaction-mode`](https://github.com/coreos/etcd/pull/8123) flag to [support revision-based compaction](https://github.com/coreos/etcd/issues/8098).
- Change `--auto-compaction-retention` flag to [accept string values](https://github.com/coreos/etcd/pull/8563) with [finer granularity](https://github.com/coreos/etcd/issues/8503).
- Now that `--auto-compaction-retention` accepts string values, etcd configuration YAML file `log-output` field must be changed to `string` type.
- Now that `--auto-compaction-retention` accepts string values, etcd configuration YAML file `auto-compaction-retention` field must be changed to `string` type.
- Previously, `--config-file etcd.config.yaml` can have `auto-compaction-retention: 24` field, now must be `auto-compaction-retention: "24"` or `auto-compaction-retention: "24h"`.
- If configured as `--auto-compaction-mode periodic --auto-compaction-retention "24h"`, the time duration value for `--auto-compaction-retention` flag must be valid for [`time.ParseDuration`](https://golang.org/pkg/time/#ParseDuration) function in Go.
- e.g. `--auto-compaction-mode=revision --auto-compaction-retention=1000` automatically `Compact` on `"latest revision" - 1000` every 5-minute (when latest revision is 30000, compact on revision 29000).
Expand Down Expand Up @@ -253,15 +253,15 @@ See [security doc](https://github.com/coreos/etcd/blob/master/Documentation/op-g
- Address [error on shadowed environment variables](https://github.com/coreos/etcd/issues/8380).
- etcd v3.4 will exit on this error.

### Added: API
### API

- Support [ranges in transaction comparisons](https://github.com/coreos/etcd/pull/8025) for [disconnected linearized reads](https://github.com/coreos/etcd/issues/7924).
- Add [nested transactions](https://github.com/coreos/etcd/pull/8102) to extend [proxy use cases](https://github.com/coreos/etcd/issues/7857).
- Add [lease comparison target in transaction](https://github.com/coreos/etcd/pull/8324).
- Add [lease list](https://github.com/coreos/etcd/pull/8358).
- Add [hash by revision](https://github.com/coreos/etcd/pull/8263) for [better corruption checking against boltdb](https://github.com/coreos/etcd/issues/8016).

### Added: `clientv3`
### `clientv3`

- Add [health balancer](https://github.com/coreos/etcd/pull/8545) to fix [watch API hangs](https://github.com/coreos/etcd/issues/7247), improve [endpoint switch under network faults](https://github.com/coreos/etcd/issues/7941).
- [Refactor balancer](https://github.com/coreos/etcd/pull/8840) and add [client-side keepalive pings](https://github.com/coreos/etcd/pull/8199) to handle [network partitions](https://github.com/coreos/etcd/issues/8711).
Expand All @@ -285,7 +285,7 @@ See [security doc](https://github.com/coreos/etcd/blob/master/Documentation/op-g
- Fix [`concurrency/stm` `Put` with serializable snapshot](https://github.com/coreos/etcd/pull/8439).
- Use store revision from first fetch to resolve write conflicts instead of modified revision.

### Added: v3 `etcdctl`
### v3 `etcdctl`

- Add [`--discovery-srv`](https://github.com/coreos/etcd/pull/8462) flag.
- Add [`--keepalive-time`, `--keepalive-timeout`](https://github.com/coreos/etcd/pull/8663) flags.
Expand All @@ -311,11 +311,11 @@ See [security doc](https://github.com/coreos/etcd/blob/master/Documentation/op-g

- Handle [empty key permission](https://github.com/coreos/etcd/pull/8514) in `etcdctl`.

### Added: v2 `etcdctl`
### v2 `etcdctl`

- Add [`backup --with-v3`](https://github.com/coreos/etcd/pull/8479) flag.

### Added: `grpc-proxy`
### `grpc-proxy`

- Add [`grpc-proxy start --experimental-leasing-prefix`](https://github.com/coreos/etcd/pull/8341) flag.
- For disconnected linearized reads.
Expand All @@ -336,7 +336,7 @@ See [security doc](https://github.com/coreos/etcd/blob/master/Documentation/op-g
- Fix [KV API `PrevKv` flag handling](https://github.com/coreos/etcd/pull/8366).
- Fix [KV API `KeysOnly` flag handling](https://github.com/coreos/etcd/pull/8552).

### Added: gRPC gateway
### gRPC gateway

- Replace [gRPC gateway](https://github.com/grpc-ecosystem/grpc-gateway) endpoint `/v3alpha` with [`/v3beta`](https://github.com/coreos/etcd/pull/8880).
- To deprecate [`/v3alpha`](https://github.com/coreos/etcd/issues/8125) in v3.4.
Expand Down
Loading