Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

content/docs/next/learning: propose v3.5 auto-promotion in design-learner.md #107

Closed

Conversation

maxenglander
Copy link

(Moved here from etcd-io/etcd#10913.)

Propose v3.5 support for having a cluster automatically promote
a learner node to a voting member when added to a cluster with
member add --learner --auto.

The changes proposed for v3.5 in this PR are implemented in etcd-io/etcd#10887

Copy link
Contributor

@ptabor ptabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. It looks good to me.

@nate-double-u
Copy link
Contributor

@maxenglander, thanks for this. Could you resolve the conflict by adding this to the content/docs/next folder rather than current?

@maxenglander maxenglander changed the title content/docs/current/learning: propose v3.5 auto-promotion in design-learner.md content/docs/next/learning: propose v3.5 auto-promotion in design-learner.md Mar 31, 2021
@maxenglander
Copy link
Author

@nate-double-u sure, done!

@nate-double-u
Copy link
Contributor

/hold for etcd-io/etcd#10887

@jberkus
Copy link
Contributor

jberkus commented Apr 20, 2023

@ptabor @nate-double-u auto-promoting learners didn't merge.

Leaving on hold while we address the original feature.

@jmhbnz
Copy link
Member

jmhbnz commented Dec 17, 2023

Closing this stale pull request as part of triage. We can always re-open in future if needed once the relevant feature is completed. Noting that there are conflicts in this pr so it might be easiest to just start fresh once the feature is merged.

@jmhbnz jmhbnz closed this Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants