Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-supervisor: Create logdb for each chain #11043

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Conversation

ajsutton
Copy link
Contributor

Description

Updates op-supervisor so that it creates a logdb database for each chain it monitors. Pretty much entirely just wiring code and moving things around to make the chain ID available as needed. The NewBackend function is getting a bit complex for my liking but going with it for now as it is just the constructor so having wiring code in there isn't too bad and I'm keen to actually get a minimal pipeline hooked up end to end before trying to guess exactly where things will land.

Metadata

Copy link
Contributor

@protolambda protolambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

For later updates I suggest we add a type ChainID uint256.Int however; then we can attach utils to the chainID, and use it as map-key (uint256.Int is an array of 4 uint64, safe to use as key, unlike *big.Int). And then we can do map[ChainID]*db.DB.

@protolambda protolambda added this pull request to the merge queue Jun 28, 2024
Merged via the queue into develop with commit 822df50 Jun 28, 2024
60 checks passed
@protolambda protolambda deleted the aj/create-logdb branch June 28, 2024 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interop: op-supervisor: Create log db for each chain
2 participants