indexer: use op-bindings for address manager #2858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Lib_AddressManager` contract was pulled into `contracts-bedrock` as a legacy contract and can be imported into `op-bindings` and build the same way that the other golang contract bindings are maintained. This is a legacy contract and should NEVER have any changes to it. It is ok if it is compiled with a different compiler version for testing, it will never be deployed to a network to be used with an Optimism system again. It is very important that the ABI never changes. Any upgrades to the network that touch this contract first must go through a `hardhat` or `anvil` forked network to ensure correctness of the upgrade.
🦋 Changeset detectedLatest commit: 39fece1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tynes
force-pushed
the
fix/indexer-op-bindings
branch
from
840a7ef
to
5d6c6bc
Compare
maurelian
approved these changes
Jun 27, 2022
mslipper
approved these changes
Jun 27, 2022
|
This PR has been added to the merge queue, and will be merged soon. |
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
1 similar comment
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
Lib_AddressManagercontract was pulled intocontracts-bedrockas a legacy contract and can beimported into
op-bindingsand build the same way thatthe other golang contract bindings are maintained.
This is a legacy contract and should NEVER have any changes to it.
It is ok if it is compiled with a different compiler version for
testing, it will never be deployed to a network to be used with an
Optimism system again. It is very important that the ABI never changes.
Any upgrades to the network that touch this contract first must go
through a
hardhatoranvilforked network to ensure correctnessof the upgrade.