Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Optimism Config in L2 Genesis builder #3075

Merged
merged 5 commits into from
Jul 21, 2022
Merged

Conversation

trianglesphere
Copy link
Contributor

Description
This places the Optimism chain config in the correct place as
well as deleting the spurious Clique config in the L2 genesis.

Metadata

  • Fixes the inability of op-nodes to direct a reorg on the L2 execution engine.

@changeset-bot
Copy link

changeset-bot bot commented Jul 21, 2022

⚠️ No Changeset found

Latest commit: b4e78dd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added 2-reviewers A-pkg-contracts-bedrock Area: packages/contracts-bedrock labels Jul 21, 2022
@mergify
Copy link
Contributor

mergify bot commented Jul 21, 2022

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

This places the Optimism chain config in the correct place as
well as deleting the spurious Clique config in the L2 genesis.
@github-actions github-actions bot added the A-pkg-core-utils Area: packages/core-utils label Jul 21, 2022
Co-authored-by: Joshua Gutow <jgutow@optimism.io>
@mergify
Copy link
Contributor

mergify bot commented Jul 21, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Jul 21, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot merged commit 707810c into develop Jul 21, 2022
@mergify mergify bot deleted the jg/fix_l2_genesis_builder branch July 21, 2022 10:08
@mergify mergify bot removed the on-merge-train label Jul 21, 2022
sam-goldman pushed a commit that referenced this pull request Sep 15, 2022
* Fix Optimism Config in L2 Genesis builder

This places the Optimism chain config in the correct place as
well as deleting the spurious Clique config in the L2 genesis.

* packages/core-utils: bedrock config type fix

* packages/contracts-bedrock: update genesis l2 task import

* packages/core-utils: bedrock - remove old todo comment

Co-authored-by: Joshua Gutow <jgutow@optimism.io>

Co-authored-by: protolambda <proto@protolambda.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-pkg-contracts-bedrock Area: packages/contracts-bedrock A-pkg-core-utils Area: packages/core-utils
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants