Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-batcher: Split batch_submitter.go into several files #3810

Merged
merged 2 commits into from
Oct 28, 2022

Conversation

trianglesphere
Copy link
Contributor

Description

This simply moves code around into new files without changing it. The intention is to tease it apart, but that is not done yet.

Tests

Still passing, this simply moves code around.

Additional context

This is part of updating the batcher & I've already started follow up work to clean this up even more. I'm happy to incorporate comments into follow up work, but I will likely be changing a lot of this code.

This simply moves code around into new files without changing it.
The intention is to tease it apart, but that is not done yet.
@changeset-bot
Copy link

changeset-bot bot commented Oct 27, 2022

⚠️ No Changeset found

Latest commit: 47e58e4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mergify
Copy link
Contributor

mergify bot commented Oct 27, 2022

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

@mergify
Copy link
Contributor

mergify bot commented Oct 28, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Oct 28, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot merged commit f9d42b8 into develop Oct 28, 2022
@mergify mergify bot deleted the jg/split_batch_submitter branch October 28, 2022 14:18
@mergify mergify bot removed the on-merge-train label Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants