-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ctb): Add correct prefix to errors #4949
Conversation
|
Hey @maurelian! This PR has merge conflicts. Please fix them before continuing review. |
e2d98d4
to
7343ab2
Compare
Can you bump minor semver for these? |
Will need to change |
Just to be sure: minor, not patch? edit: I see, yeah minor. |
Hey @maurelian! This PR has merge conflicts. Please fix them before continuing review. |
7343ab2
to
d90bca6
Compare
d90bca6
to
098e803
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #4949 +/- ##
============================================
+ Coverage 22.65% 40.02% +17.36%
============================================
Files 113 303 +190
Lines 9561 18971 +9410
Branches 0 655 +655
============================================
+ Hits 2166 7593 +5427
- Misses 7159 10776 +3617
- Partials 236 602 +366
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This PR has been added to the merge queue, and will be merged soon. |
This PR is next in line to be merged, and will be merged as soon as checks pass. |
Description
Fixes some error messages that were inconsistent with our style guide.