Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ctb): Add correct prefix to errors #4949

Merged
merged 2 commits into from
Feb 23, 2023
Merged

Conversation

maurelian
Copy link
Contributor

Description

Fixes some error messages that were inconsistent with our style guide.

@maurelian maurelian requested a review from a team as a code owner February 23, 2023 02:05
@maurelian maurelian requested a review from tynes February 23, 2023 02:05
@changeset-bot
Copy link

changeset-bot bot commented Feb 23, 2023

⚠️ No Changeset found

Latest commit: a01241f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mergify
Copy link
Contributor

mergify bot commented Feb 23, 2023

Hey @maurelian! This PR has merge conflicts. Please fix them before continuing review.

@tynes
Copy link
Contributor

tynes commented Feb 23, 2023

Can you bump minor semver for these?

@tynes
Copy link
Contributor

tynes commented Feb 23, 2023

Will need to change check-l2 hh task and regenerate bindings as well

@maurelian
Copy link
Contributor Author

maurelian commented Feb 23, 2023

Can you bump minor semver for these?

Just to be sure: minor, not patch?

edit: I see, yeah minor.

@mergify
Copy link
Contributor

mergify bot commented Feb 23, 2023

Hey @maurelian! This PR has merge conflicts. Please fix them before continuing review.

@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Merging #4949 (098e803) into develop (34e13a5) will increase coverage by 17.36%.
The diff coverage is 100.00%.

❗ Current head 098e803 differs from pull request most recent head a01241f. Consider uploading reports for the commit a01241f to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop    #4949       +/-   ##
============================================
+ Coverage    22.65%   40.02%   +17.36%     
============================================
  Files          113      303      +190     
  Lines         9561    18971     +9410     
  Branches         0      655      +655     
============================================
+ Hits          2166     7593     +5427     
- Misses        7159    10776     +3617     
- Partials       236      602      +366     
Flag Coverage Δ
bedrock-go-tests 35.94% <ø> (+13.28%) ⬆️
contracts-bedrock-tests 49.43% <100.00%> (?)
contracts-tests 98.86% <ø> (?)
dtl-tests 47.15% <ø> (?)
fault-detector-tests 33.88% <ø> (?)
sdk-tests 38.74% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../contracts-bedrock/contracts/L1/L1ERC721Bridge.sol 100.00% <100.00%> (ø)
.../contracts-bedrock/contracts/L2/L2ERC721Bridge.sol 76.92% <100.00%> (ø)
packages/sdk/tasks/deposit-erc20.ts 6.25% <0.00%> (ø)
op-node/heartbeat/service.go 55.26% <0.00%> (ø)
...ts-bedrock/contracts/deployment/SystemDictator.sol 0.00% <0.00%> (ø)
...ontracts-bedrock/contracts/L1/ResourceMetering.sol 0.00% <0.00%> (ø)
.../contracts/L2/messaging/L2StandardTokenFactory.sol 100.00% <0.00%> (ø)
op-node/node/client.go 0.00% <0.00%> (ø)
op-node/node/log.go 0.00% <0.00%> (ø)
op-node/node/server.go 55.55% <0.00%> (ø)
... and 214 more

@mergify
Copy link
Contributor

mergify bot commented Feb 23, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Feb 23, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot removed the on-merge-train label Feb 23, 2023
@mslipper mslipper merged commit fbe14d5 into develop Feb 23, 2023
@mslipper mslipper deleted the jm/fix-error-strings branch February 23, 2023 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants