op-node: regolith fork systemtx change #4961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
mslipper
reviewed
Feb 23, 2023
mslipper
approved these changes
Feb 23, 2023
lightscale-luke
added a commit
to kroma-network/zkevm-circuits
that referenced
this pull request
Jun 20, 2023
- Update system deposit tx gas limit. See ethereum-optimism/optimism#4961 - Add `ValidatorRewardRatio` argument to `setL1BlockValues`.
lightscale-luke
added a commit
to kroma-network/zkevm-circuits
that referenced
this pull request
Jun 20, 2023
- Update system deposit tx gas limit. See ethereum-optimism/optimism#4961 - Add `ValidatorRewardRatio` argument to `setL1BlockValues`.
lightscale-luke
added a commit
to kroma-network/zkevm-circuits
that referenced
this pull request
Jun 20, 2023
- Renaming of FeeVaults:
Previously, the names of the vaults were based on the source of funds,
but now they are named based on the purpose of the funds.
Before: BaseFeeVault, PriorityFeeVault, RollupFeeVault
After: ValidatorRewardVault, ProtocolVault, ProposerRewardVault
- Supporting Validator decentralization:
* Previously, the fee that meant to be burnt on Ethereum were
colellected to BaseFeeVault.
* With validator decentrailization, the fee is distributed to
ValidatorRewardVault and ProtocolVault.
* The distribution is validated on `VpRewardHook` step
(Validator Protocol Reward Hook).
Calcuation on the step is done as follow:
e.g.
Total reward = 20001, validator reward ratio = 2000
Validator reward = Floor(20001 * 2000 / 10000) = 4000
-> to ValidatorRewardVault
Protocol reward = 20001 - 4000 = 16001
-> to ProtocolVault
- ProposerRewardVault is similar to RollupFeeVault
test) Mocking variables and functions modified:
- Update system deposit tx gas limit.
See ethereum-optimism/optimism#4961
- Add `ValidatorRewardRatio` argument to `setL1BlockValues`.
lightscale-luke
added a commit
to kroma-network/zkevm-circuits
that referenced
this pull request
Jul 17, 2023
- Renaming of FeeVaults:
Previously, the names of the vaults were based on the source of funds,
but now they are named based on the purpose of the funds.
Before: BaseFeeVault, PriorityFeeVault, RollupFeeVault
After: ValidatorRewardVault, ProtocolVault, ProposerRewardVault
- Supporting Validator decentralization:
* Previously, the fee that meant to be burnt on Ethereum were
colellected to BaseFeeVault.
* With validator decentrailization, the fee is distributed to
ValidatorRewardVault and ProtocolVault.
* The distribution is validated on `VpRewardHook` step
(Validator Protocol Reward Hook).
Calcuation on the step is done as follow:
e.g.
Total reward = 20001, validator reward ratio = 2000
Validator reward = Floor(20001 * 2000 / 10000) = 4000
-> to ValidatorRewardVault
Protocol reward = 20001 - 4000 = 16001
-> to ProtocolVault
- ProposerRewardVault is similar to RollupFeeVault
test) Mocking variables and functions modified:
- Update system deposit tx gas limit.
See ethereum-optimism/optimism#4961
- Add `ValidatorRewardRatio` argument to `setL1BlockValues`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement the Regolith
is-system-tx == falsechange, and set the l1-info-tx gas to 1M gas.Tests
This only tests the derivation-pipeline change, which is a relatively small part of Regolith. Once the op-geth changes land and get pulled in as op-node dependency we can implement full e2e-tests (and update existing tests to also run regolith more).
Metadata
Fix CLI-3462