Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-e2e: Add e2e tests for bedrock behaviour that will change in regolith #4962

Merged
merged 3 commits into from
Feb 24, 2023

Conversation

ajsutton
Copy link
Contributor

Description

Adds tests to confirm that the behaviour that will change in regolith is unchanged if regolith isn't scheduled.

Additional context

Builds on #4957

@ajsutton ajsutton requested a review from a team as a code owner February 23, 2023 22:39
@ajsutton ajsutton requested review from protolambda and removed request for a team February 23, 2023 22:39
@changeset-bot
Copy link

changeset-bot bot commented Feb 23, 2023

⚠️ No Changeset found

Latest commit: 3975afd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mergify
Copy link
Contributor

mergify bot commented Feb 23, 2023

Hey @ajsutton! This PR has merge conflicts. Please fix them before continuing review.

op-e2e/op_geth_test.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Merging #4962 (51a1208) into develop (cd36e68) will decrease coverage by 4.77%.
The diff coverage is n/a.

❗ Current head 51a1208 differs from pull request most recent head 3975afd. Consider uploading reports for the commit 3975afd to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4962      +/-   ##
===========================================
- Coverage    40.90%   36.14%   -4.77%     
===========================================
  Files          324      183     -141     
  Lines        19648    15536    -4112     
  Branches       770        0     -770     
===========================================
- Hits          8037     5615    -2422     
+ Misses       11008     9355    -1653     
+ Partials       603      566      -37     
Flag Coverage Δ
bedrock-go-tests 36.14% <ø> (-0.10%) ⬇️
contracts-bedrock-tests ?
contracts-tests ?
core-utils-tests ?
dtl-tests ?
fault-detector-tests ?
sdk-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
op-chain-ops/genesis/setters.go 53.48% <0.00%> (-12.92%) ⬇️
...contracts-bedrock/contracts/libraries/SafeCall.sol
.../contracts/L2/messaging/L2CrossDomainMessenger.sol
.../contracts/L2/predeploys/OVM_SequencerFeeVault.sol
...ckages/data-transport-layer/src/utils/contracts.ts
packages/core-utils/src/optimism/index.ts
...racts-bedrock/contracts/governance/MintManager.sol
packages/sdk/src/utils/chain-constants.ts
packages/core-utils/src/common/index.ts
...cts/contracts/L2/predeploys/OVM_GasPriceOracle.sol
... and 132 more

@mergify
Copy link
Contributor

mergify bot commented Feb 24, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Feb 24, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot merged commit aa766f2 into develop Feb 24, 2023
@mergify mergify bot deleted the aj/bedrock-e2e branch February 24, 2023 22:42
@mergify mergify bot removed the on-merge-train label Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants