You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a limit to prevent calldata larger than 120kb. Unsafe blocks contain the deposit transactions and when there is no upper bound on the calldata size, it is possible for a single transaction to cause the p2p gossip to consume far more bandwidth than necessary.
#5529 should be merged first because of the semver bumping
Tests
Includes test coverage of the new revert condition
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Hey @tynes, this pull request failed to merge and has been dequeued from the merge train. If you believe your PR failed in the merge train because of a flaky test, requeue it by commenting with @mergifyio requeue.
More details can be found on the Queue: Embarked in merge train check-run.
Adds a limit to prevent calldata larger than 120kb. Unsafe
blocks contain the deposit transactions and when there is
no upper bound on the calldata size, it is possible for a
single transaction to cause the p2p gossip to consume
far more bandwidth than necessary.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tynes
force-pushed
the
fix/max-deposit-data
branch
from
Description
Adds a limit to prevent calldata larger than 120kb. Unsafe blocks contain the deposit transactions and when there is no upper bound on the calldata size, it is possible for a single transaction to cause the p2p gossip to consume far more bandwidth than necessary.
#5529 should be merged first because of the
semverbumpingTests
Includes test coverage of the new revert condition
Fixes CLI-3847