Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ctb): Update Portal comments #6146

Merged
merged 1 commit into from
Jun 26, 2023
Merged

fix(ctb): Update Portal comments #6146

merged 1 commit into from
Jun 26, 2023

Conversation

maurelian
Copy link
Contributor

@maurelian maurelian commented Jun 26, 2023

Description

Two corrections made here to the Portal comments:

  1. pause() only affects withdrawals, not deposits
  2. the _gasLimit argument in depositTransaction() is not a minimum. I suspect that goes back to some earlier deposit fee design ideas.

@maurelian maurelian requested a review from a team as a code owner June 26, 2023 17:30
@changeset-bot
Copy link

changeset-bot bot commented Jun 26, 2023

⚠️ No Changeset found

Latest commit: eb58b74

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Jun 26, 2023

Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit eb58b74
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/6499cb51ef482100089b8815

@github-actions github-actions bot added the C-protocol-critical Category: Modifies protocol-critical code label Jun 26, 2023
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #6146 (eb58b74) into develop (0119b6c) will increase coverage by 0.63%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6146      +/-   ##
===========================================
+ Coverage    45.28%   45.91%   +0.63%     
===========================================
  Files          381      410      +29     
  Lines        27290    27471     +181     
  Branches       478      533      +55     
===========================================
+ Hits         12357    12613     +256     
+ Misses       13927    13806     -121     
- Partials      1006     1052      +46     
Flag Coverage Δ
bedrock-go-tests 44.97% <ø> (+<0.01%) ⬆️
cannon-go-tests 61.71% <ø> (ø)
common-ts-tests ?
contracts-bedrock-tests 58.16% <ø> (?)
core-utils-tests ?
fault-detector-tests 26.95% <ø> (ø)
sdk-tests 39.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../contracts-bedrock/contracts/L1/OptimismPortal.sol 87.75% <ø> (ø)

... and 87 files with indirect coverage changes

@maurelian maurelian merged commit 0e2e711 into develop Jun 26, 2023
10 checks passed
@maurelian maurelian deleted the jm/portal-docs branch June 26, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-protocol-critical Category: Modifies protocol-critical code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants