Submit EIP-4973 - Account-bound tokens #4973

TimDaub · 2022-04-05T09:45:33Z

ERC1238: Non-transferrable Non-Fungible Tokens (NTT) #1238
Addressed all comments by @MicahZoltu from Add EIP-1238.md #4966
Resubmitted PR as it was closed because of April 1 ("it's not a joke")
Discussion: https://ethereum-magicians.org/t/eip-4973-non-transferrable-non-fungible-tokens-soulbound-tokens-or-badges/8825
Tested reference implementation is currently here: https://github.com/rugpullindex/ERC4973

Changes made after initial submission based on discussion on Ethereum Magicians forum:

eth-bot · 2022-04-05T09:46:18Z

All tests passed; auto-merging...

(pass) eip-4973.md

classification
`updateEIP`

passed!

(pass) assets/eip-4973/src/ERC165.sol

classification
`ambiguous`

file assets/eip-4973/src/ERC165.sol is associated with EIP 4973; because there are also changes being made to EIPS/eip-4973.md all changes to corresponding assets are also allowed

(pass) assets/eip-4973/src/ERC4973.sol

classification
`ambiguous`

file assets/eip-4973/src/ERC4973.sol is associated with EIP 4973; because there are also changes being made to EIPS/eip-4973.md all changes to corresponding assets are also allowed

(pass) assets/eip-4973/src/ERC4973.t.sol

classification
`ambiguous`

file assets/eip-4973/src/ERC4973.t.sol is associated with EIP 4973; because there are also changes being made to EIPS/eip-4973.md all changes to corresponding assets are also allowed

(pass) assets/eip-4973/src/interfaces/IERC165.sol

classification
`ambiguous`

file assets/eip-4973/src/interfaces/IERC165.sol is associated with EIP 4973; because there are also changes being made to EIPS/eip-4973.md all changes to corresponding assets are also allowed

(pass) assets/eip-4973/src/interfaces/IERC4973.sol

classification
`ambiguous`

file assets/eip-4973/src/interfaces/IERC4973.sol is associated with EIP 4973; because there are also changes being made to EIPS/eip-4973.md all changes to corresponding assets are also allowed

(pass) assets/eip-4973/src/interfaces/IERC721Metadata.sol

classification
`ambiguous`

file assets/eip-4973/src/interfaces/IERC721Metadata.sol is associated with EIP 4973; because there are also changes being made to EIPS/eip-4973.md all changes to corresponding assets are also allowed

EIPS/eip-4966.md

TimDaub · 2022-04-10T15:16:07Z

@SamWilsn I've addressed all your comments and generally edited the text such that it now complies better with the structure outlined in ERC-1. I've also now renamed it finally to ERC4973, the number of this issue. Please let me know how to proceed.

EIPS/eip-4973.md

assets/eip-4973/src/ERC4973.sol

assets/eip-4973/src/ERC4973.t.sol

assets/eip-4973/src/interfaces/IERC4973.sol

assets/eip-4973/src/interfaces/IERC721Metadata.sol

Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>

TimDaub · 2022-04-18T10:11:17Z

Updates from 2022-04-18:

Added section on revocations.
Changed name to "Account-bound tokens."
Added section on exception handling in cases of key loss.

Co-authored-by: Micah Zoltu <micah@zoltu.net>

EIPS/eip-4973.md

SamWilsn

I think the remaining comments can be fixed while this EIP is a draft.

SamWilsn · 2022-05-13T20:56:53Z

EIPS/eip-4973.md

+---
+eip: 4973
+title: Account-bound Tokens
+description: A standard interface for non-transferrable non-fungible tokens, also known as "account-bound" or "soulbound tokens" or "badges".


I'd recommend removing "standard", but I think it's fine to leave in for the draft.

Suggested change

description: A standard interface for non-transferrable non-fungible tokens, also known as "account-bound" or "soulbound tokens" or "badges".

description: An interface for non-transferrable non-fungible tokens, also known as "account-bound" or "soulbound tokens" or "badges".

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

MicahZoltu · 2022-05-16T06:46:04Z

No idea why CI is failing... kicking to try to resolve it.

MicahZoltu · 2022-05-16T06:54:11Z

CI is failing with this error, but that file does exist so I'm not sure what the problem is:

- ./_site/EIPS/eip-4973.html
  *  internally linking to ./eip-721.md`, which does not exist (line 237)
     <a href="./eip-721.md`"></a>

MicahZoltu · 2022-05-16T06:54:50Z

If someone can help me track down exactly why CI is failing for this that would be super helpful! Maybe there is some non-ascii character somewhere or something?

EIPS/eip-4973.md

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

* Add EIP-1238.md * Rename from 1238 to 4966 * Address feedback from PR * Change name from 4966 to 4973 * Fix header property order * Remove 79 character manual word wrapping * Fix syntax error for incomplete link tag * Remove Caveat section (for now) * Clarify standards text * Run through grammarly * Update discussion link * Update EIPS/eip-4973.md Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com> * Update EIPS/eip-4973.md Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com> * Update EIPS/eip-4973.md Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com> * Update EIPS/eip-4973.md Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com> * Relicense to CC0-1.0 * More copyediting * Rename from "Soulbound" to "Account-bound" tokens * Add section on "Exception handling" * Add section on revocation * Update EIPS/eip-4973.md Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com> * Rename to 'Account-bound Tokens' * Correct co-author section * Correct TLA from non-sensical 'ACT' to 'ABT' - ABT stands for "Account-bound token" * Remove superfluous, explicit interface definitions * Add 'Naming' section * Consistently use EIP-XXXX format * Remove reference to badge concept * Correctly apply camelCase in tests * Update reference implementation - Vendor all third-party code (OZ) - Allowing to mint to third-party address - Rename `_bonds` to `_owners` - Fix TLA from ACT to ABT - Fix ABT name in tests * Replace `event Transfer` w/ Attest/Revoke * Fix username prefix in author field Co-authored-by: Micah Zoltu <micah@zoltu.net> * Fix broken link to eip-721.md Co-authored-by: Micah Zoltu <micah@zoltu.net> * Fix typo Co-authored-by: Micah Zoltu <micah@zoltu.net> * Fix link to reference implementation Co-authored-by: Micah Zoltu <micah@zoltu.net> * Update EIPS/eip-4973.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-4973.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com> Co-authored-by: Micah Zoltu <micah@zoltu.net> Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

ethereum/EIPs#4973

inso- · 2022-06-12T03:00:43Z

@TimDaub I think it would be good to have hooks _beforeTokenTransfer and _afterTokenTransfer (on _mint and _burn) for extensibility (to allow extension like ERC4973Enumerable to be build in the future), like on ERC721.

MicahZoltu · 2022-06-12T04:50:33Z

@inso- I recommend commenting on the discussions-to link in the EIP so your comment gets appropriate visibility.

TimDaub · 2022-06-13T15:37:51Z

@inso-

the reference implementation has _burn and _mint. We're tracking commits as a separate repo here: https://github.com/rugpullindex/ERC4973

* Add EIP-1238.md * Rename from 1238 to 4966 * Address feedback from PR * Change name from 4966 to 4973 * Fix header property order * Remove 79 character manual word wrapping * Fix syntax error for incomplete link tag * Remove Caveat section (for now) * Clarify standards text * Run through grammarly * Update discussion link * Update EIPS/eip-4973.md Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com> * Update EIPS/eip-4973.md Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com> * Update EIPS/eip-4973.md Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com> * Update EIPS/eip-4973.md Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com> * Relicense to CC0-1.0 * More copyediting * Rename from "Soulbound" to "Account-bound" tokens * Add section on "Exception handling" * Add section on revocation * Update EIPS/eip-4973.md Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com> * Rename to 'Account-bound Tokens' * Correct co-author section * Correct TLA from non-sensical 'ACT' to 'ABT' - ABT stands for "Account-bound token" * Remove superfluous, explicit interface definitions * Add 'Naming' section * Consistently use EIP-XXXX format * Remove reference to badge concept * Correctly apply camelCase in tests * Update reference implementation - Vendor all third-party code (OZ) - Allowing to mint to third-party address - Rename `_bonds` to `_owners` - Fix TLA from ACT to ABT - Fix ABT name in tests * Replace `event Transfer` w/ Attest/Revoke * Fix username prefix in author field Co-authored-by: Micah Zoltu <micah@zoltu.net> * Fix broken link to eip-721.md Co-authored-by: Micah Zoltu <micah@zoltu.net> * Fix typo Co-authored-by: Micah Zoltu <micah@zoltu.net> * Fix link to reference implementation Co-authored-by: Micah Zoltu <micah@zoltu.net> * Update EIPS/eip-4973.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> * Update EIPS/eip-4973.md Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com> Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com> Co-authored-by: Micah Zoltu <micah@zoltu.net> Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

rotcivegaf · 2023-05-12T23:27:42Z

I played wow in my old days, the idea of soulbound items is that they couldn't be transferred and the only way to remove them was to destroy them

This goes against the specification that the unequip function says that the item can be re-equipable:
"Removes the uint256 tokenId from an account. At any time, an ABT receiver must be able to disassociate themselves from an ABT publicly through calling this function. After successfully executing this function, given the parameters for calling function give or function take a token must be re-equipable."

I don't think this should be re-equipable

Look this case:

Alice signs a give transaction to allow Tom to give her an ABT
Tom give this ABT to alice
Alice unequip the ABT
Tom haves the give transaction and can give the ABT to Alice again, and again
Finally, Tom can spam Alice giving the ABT every time Alice unequip it

TimDaub · 2023-05-13T07:40:51Z

ok I‘m open to it

TimDaub added 3 commits April 1, 2022 23:11

Add EIP-1238.md

b8e717d

Rename from 1238 to 4966

391cca9

Address feedback from PR

9754700

TimDaub mentioned this pull request Apr 5, 2022

Add EIP-1238.md #4966

Closed

eth-bot added ambiguous labels Apr 5, 2022

SamWilsn reviewed Apr 6, 2022

View reviewed changes

TimDaub added 5 commits April 10, 2022 16:04

Change name from 4966 to 4973

8d7368e

Fix header property order

6c2a00c

Remove 79 character manual word wrapping

40522db

Fix syntax error for incomplete link tag

2e2dd82

Remove Caveat section (for now)

82dc89a

TimDaub changed the title ~~Resubmit EIP-4966~~ Submit EIP-4973 Apr 10, 2022

Clarify standards text

503d9c5

TimDaub force-pushed the master branch from eaa0b25 to 503d9c5 Compare April 10, 2022 14:56

Run through grammarly

c5dfe52

Update discussion link

48304f8

SamWilsn reviewed Apr 14, 2022

View reviewed changes

TimDaub and others added 9 commits April 18, 2022 10:21

Update EIPS/eip-4973.md

cd26e76

Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>

Update EIPS/eip-4973.md

c6b6c2b

Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>

Update EIPS/eip-4973.md

594bdaa

Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>

Update EIPS/eip-4973.md

f2bf116

Co-authored-by: Sam Wilson <57262657+SamWilsn@users.noreply.github.com>

Relicense to CC0-1.0

73525e9

More copyediting

b71be06

Rename from "Soulbound" to "Account-bound" tokens

bc16f29

Add section on "Exception handling"

9e26685

Add section on revocation

a68efbe

TimDaub and others added 2 commits May 9, 2022 14:28

Fix typo

1aefe9a

Co-authored-by: Micah Zoltu <micah@zoltu.net>

Fix link to reference implementation

acdc991

Co-authored-by: Micah Zoltu <micah@zoltu.net>

Pandapip1 reviewed May 13, 2022

View reviewed changes

EIPS/eip-4973.md Outdated Show resolved Hide resolved

SamWilsn approved these changes May 13, 2022

View reviewed changes

eth-bot added updateEIP and removed newEIPFile labels May 13, 2022

eth-bot enabled auto-merge (squash) May 13, 2022 21:04

Update EIPS/eip-4973.md

50d2c65

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

MicahZoltu closed this May 16, 2022

auto-merge was automatically disabled May 16, 2022 06:46
Pull request was closed

MicahZoltu reopened this May 16, 2022

eth-bot enabled auto-merge (squash) May 16, 2022 06:47

Pandapip1 reviewed May 16, 2022

View reviewed changes

EIPS/eip-4973.md Outdated Show resolved Hide resolved

poojaranjan mentioned this pull request May 17, 2022

EIP editor apprenticeship meeting 17 ethcatherders/EIPIP#135

Closed

Update EIPS/eip-4973.md

194f910

Co-authored-by: Pandapip1 <45835846+Pandapip1@users.noreply.github.com>

auto-merge was automatically disabled May 18, 2022 10:56
Head branch was pushed to by a user without write access

eth-bot enabled auto-merge (squash) May 18, 2022 10:57

eth-bot merged commit d5858d2 into ethereum:master May 18, 2022

FilipLaurentiu added a commit to FilipLaurentiu/soulbound-cairo that referenced this pull request Jun 6, 2022

Cairo basic implementation of ERC4973

105e850

ethereum/EIPs#4973

rotcivegaf mentioned this pull request May 15, 2023

Update EIP-4973: When unequip the token must not be re-equipable #7032

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Submit EIP-4973 - Account-bound tokens #4973

Submit EIP-4973 - Account-bound tokens #4973

TimDaub commented Apr 5, 2022 •

edited

Loading

eth-bot commented Apr 5, 2022 •

edited

Loading

TimDaub commented Apr 10, 2022

TimDaub commented Apr 18, 2022

SamWilsn left a comment

SamWilsn May 13, 2022

MicahZoltu commented May 16, 2022 •

edited

Loading

MicahZoltu commented May 16, 2022

MicahZoltu commented May 16, 2022

inso- commented Jun 12, 2022

MicahZoltu commented Jun 12, 2022

TimDaub commented Jun 13, 2022

rotcivegaf commented May 12, 2023 •

edited

Loading

TimDaub commented May 13, 2023

	description: A standard interface for non-transferrable non-fungible tokens, also known as "account-bound" or "soulbound tokens" or "badges".
	description: An interface for non-transferrable non-fungible tokens, also known as "account-bound" or "soulbound tokens" or "badges".

Submit EIP-4973 - Account-bound tokens #4973

Submit EIP-4973 - Account-bound tokens #4973

Conversation

TimDaub commented Apr 5, 2022 • edited Loading

eth-bot commented Apr 5, 2022 • edited Loading

All tests passed; auto-merging...

(pass) eip-4973.md

(pass) assets/eip-4973/src/ERC165.sol

(pass) assets/eip-4973/src/ERC4973.sol

(pass) assets/eip-4973/src/ERC4973.t.sol

(pass) assets/eip-4973/src/interfaces/IERC165.sol

(pass) assets/eip-4973/src/interfaces/IERC4973.sol

(pass) assets/eip-4973/src/interfaces/IERC721Metadata.sol

TimDaub commented Apr 10, 2022

TimDaub commented Apr 18, 2022

SamWilsn left a comment

Choose a reason for hiding this comment

SamWilsn May 13, 2022

Choose a reason for hiding this comment

MicahZoltu commented May 16, 2022 • edited Loading

MicahZoltu commented May 16, 2022

MicahZoltu commented May 16, 2022

inso- commented Jun 12, 2022

MicahZoltu commented Jun 12, 2022

TimDaub commented Jun 13, 2022

rotcivegaf commented May 12, 2023 • edited Loading

TimDaub commented May 13, 2023

TimDaub commented Apr 5, 2022 •

edited

Loading

eth-bot commented Apr 5, 2022 •

edited

Loading

MicahZoltu commented May 16, 2022 •

edited

Loading

rotcivegaf commented May 12, 2023 •

edited

Loading