Give liveness epoch same "shape" as attester duties #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethereum#131 introduced a new liveness endpoint - the request is similar to attester duties in that we query a list of attesters for data pertaining to a particular epoch - as such, it seems reasonable to keep the two requests similar in terms of their URL/postdata structure.
|
cc @paulhauner |
|
my understanding was that it's not really something we can query for anything but current or previous epoch... it seems that the epoch field is just going to result in false unless it's very carefully used... |
it's allowed, just not required - the data could be synthesized from a state for example, or if a client wants to implement "deep" doppelganger protection (ie more than 2 epochs of silence) |
|
to me this makes sense overall, just would like to hear from @paulhauner and potentially @mehdi-aouadi to get opinions of people implementing... |
|
Change looks good to me 👍 |
This was referenced Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#131 introduced a new liveness endpoint - the request is similar to attester duties in that we query a list of validators for data pertaining to a particular epoch - as such, it seems reasonable to keep the two requests similar in terms of their URL/postdata structure.