Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graphql: add raw fields to block and tx #220

Merged
merged 1 commit into from
May 19, 2022
Merged

Conversation

s1na
Copy link
Contributor

@s1na s1na commented May 9, 2022

Adds the consensus encoding of the following types to the graphql schema:

  • block
  • block.header
  • transaction
  • transaction.receipt

These fields can be computed on the client side so they're not strictly necessary. But having them as part of the schema makes debugging easier. It was first raised for receipts as part of ethereum/go-ethereum#24720 and then extended to other types. Implementation in geth: ethereum/go-ethereum#24816 and ethereum/go-ethereum#24738

Copy link
Member

@lightclient lightclient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lightclient lightclient merged commit a0e46b4 into ethereum:main May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants