Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

engine: Remove engine_getPayloadBodiesBy{Hash|Range}V2 #586

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

engine: Remove engine_getPayloadBodiesBy{Hash|Range}V2 #586

wants to merge 1 commit into from

Conversation

mkalinin
Copy link
Collaborator

@mkalinin mkalinin commented Sep 18, 2024 •
edited
Loading

Removes engine_getPayloadBodiesByHashV2 and engine_getPayloadBodiesByRangeV2 methods assuming that CL clients will keep requests in its databases due to ethereum/consensus-specs#3875, thus requesting this data from EL is no longer required

Resolves ethereum/consensus-specs#3912

@mkalinin mkalinin mentioned this pull request Sep 18, 2024
Closed
ralexstokes
ralexstokes approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we added this for early Pectra, and if it was just to handle the pruned execution requests we can definitely drop it now

as we refactored the execution requests so they are no longer pruned

@lucassaldanha lucassaldanha mentioned this pull request Sep 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ralexstokes ralexstokes ralexstokes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove engine_getPayloadBodiesBy{Hash|Range}V2
2 participants
@mkalinin @ralexstokes