cmd, dashboard, ethdb, vendor: send iostats to dashboard #16277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karalabe
force-pushed
the
dashboard-footer-iostats
branch
from
b815ccb
to
76b6d28
Compare
karalabe
reviewed
Mar 8, 2018
ethdb/database.go
Outdated
| func (db *LDBDatabase) meter(refresh time.Duration) { | ||
| // Create the counters to store current and previous values | ||
| counters := make([][]float64, 2) | ||
| for i := 0; i < 2; i++ { | ||
| counters[i] = make([]float64, 3) | ||
| } | ||
| // Create storage for iostats. | ||
| var curr, prev [2]float64 |
There was a problem hiding this comment.
You only need to track the previous values, there's no point to pre-declare a curr array too. Also previously we only gathered compaction stats, so names like counters was good enough, since there wasn't ambiguity. With the added iostats, counters and curr and prev all of a sudden don't mean anything.
Please rename counters to compactions and curr/prev to iostats.
karalabe
requested changes
Mar 8, 2018
kurkomisi
force-pushed
the
dashboard-footer-iostats
branch
from
76b6d28
to
7fabe6b
Compare
karalabe
reviewed
Mar 8, 2018
ethdb/database.go
Outdated
| curr[0], _ = strconv.ParseFloat(strings.Split(parts[0], ":")[1], 64) | ||
| curr[1], _ = strconv.ParseFloat(strings.Split(parts[1], ":")[1], 64) | ||
| read, _ := strconv.ParseFloat(strings.Split(parts[0], ":")[1], 64) | ||
| write, _ := strconv.ParseFloat(strings.Split(parts[1], ":")[1], 64) |
There was a problem hiding this comment.
Please handle any error, otherwise this will blow up the stats.
kurkomisi
force-pushed
the
dashboard-footer-iostats
branch
from
7fabe6b
to
3d0181b
Compare
karalabe
reviewed
Mar 8, 2018
| db.log.Error("Read entry parsing failed", "err", err) | ||
| return | ||
| } | ||
| w := strings.Split(parts[1], ":") |
There was a problem hiding this comment.
This will panic if len(parts) == 1
karalabe
reviewed
Mar 8, 2018
ethdb/database.go
Outdated
| return | ||
| } | ||
| w := strings.Split(parts[1], ":") | ||
| if len(r) < 1 { |
kurkomisi
force-pushed
the
dashboard-footer-iostats
branch
from
034caea
to
6a5af0a
Compare
karalabe
reviewed
Mar 8, 2018
ethdb/database.go
Outdated
| return | ||
| } | ||
| w := strings.Split(parts[1], ":") | ||
| if len(r) < 2 { |
prestonvanloon
pushed a commit
to prestonvanloon/go-ethereum
that referenced
this pull request
Apr 2, 2018
* cmd, dashboard, ethdb, vendor: send iostats to dashboard * ethdb: change names * ethdb: handle parsing errors * ethdb: handle iostats syntax error * ethdb: r -> w
hackmod
pushed a commit
to OpenCommunityCoin/go-esn
that referenced
this pull request
Jul 9, 2018
* cmd, dashboard, ethdb, vendor: send iostats to dashboard * ethdb: change names * ethdb: handle parsing errors * ethdb: handle iostats syntax error * ethdb: r -> w
mariameda
pushed a commit
to NiluPlatform/go-nilu
that referenced
this pull request
Aug 23, 2018
* cmd, dashboard, ethdb, vendor: send iostats to dashboard * ethdb: change names * ethdb: handle parsing errors * ethdb: handle iostats syntax error * ethdb: r -> w
firmianavan
pushed a commit
to firmianavan/go-ethereum
that referenced
this pull request
Aug 28, 2018
* cmd, dashboard, ethdb, vendor: send iostats to dashboard * ethdb: change names * ethdb: handle parsing errors * ethdb: handle iostats syntax error * ethdb: r -> w
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the
goleveldbvendor package.Collect the effective amount of disk RW and send it to the dashboard.
Remove the old RW metrics.
Only the last commit is relevant, the previous ones are part of this PR #16263