les: fix CHT field in nodeInfo #17465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karalabe
reviewed
Aug 21, 2018
| } | ||
| if sections > 0 { | ||
| sectionIndex := sections - 1 | ||
| sectionHead := c.bloomTrieIndexer.SectionHead(sectionIndex) |
There was a problem hiding this comment.
if sections2 < sections, this will refer to non existent section head.
There was a problem hiding this comment.
or the other way around, either way, the head will be invalid if section != section2.
There was a problem hiding this comment.
No. sectionIndex is the last section which both indexers have so both of them should have the section head for it.
firmianavan
pushed a commit
to firmianavan/go-ethereum
that referenced
this pull request
Aug 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the empty CHT field of admin.nodeInfo in light server mode