p2p, p2p/discover: add signed ENR generation #17753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zsfelfoldi
reviewed
Sep 27, 2018
zsfelfoldi
reviewed
Sep 27, 2018
zsfelfoldi
reviewed
Sep 27, 2018
p2p/netutil/iptrack.go
Outdated
| it.gcContact(now) | ||
| it.gcStatements(now) | ||
| for host := range it.statements { | ||
| if _, ok := it.contact[host]; !ok { |
There was a problem hiding this comment.
You should also return true if you have received the statement before the contact.
|
@zsfelfoldi PTAL |
zsfelfoldi
approved these changes
Oct 5, 2018
| if ln.staticIP != nil { | ||
| newIP = ln.staticIP | ||
| } else if ip, port := predictAddr(ln.udpTrack); ip != nil { |
There was a problem hiding this comment.
Is it ok to use the static IP with the fallback UDP port? Shouldn't we add a StaticUDP parameter?
There was a problem hiding this comment.
It doesn't make sense because there is no way to set such a port via anything in geth.
|
I'm still debugging the hang in the tests on CI. The test that hangs is the swarm discovery simulation. |
LocalNode produces signed node records for the local node.
Startup is much faster because it doesn't need to wait for the external IP query anymore.
The discovery protocol sends pings to previously-unseen nodes after receiving a ping from them. This means there will always be a contact entry and PredictFullConeNAT will always return false. Fix it by checking that the contact occurred after the IP statement.
This makes the node URL in logs correct immediately after startup.
This prevents indefinite memory growth if Predict* isn't called.
This fixes a leveldb crash in tests.
19 tasks
wanwiset25
pushed a commit
to XinFinOrg/XDPoSChain
that referenced
this pull request
Jun 19, 2024
This PR adds enode.LocalNode and integrates it into the p2p subsystem. This new object is the keeper of the local node record. For now, a new version of the record is produced every time the client restarts. We'll make it smarter to avoid that in the future. There are a couple of other changes in this commit: discovery now waits for all of its goroutines at shutdown and the p2p server now closes the node database after discovery has shut down. This fixes a leveldb crash in tests. p2p server startup is faster because it doesn't need to wait for the external IP query anymore.
wanwiset25
pushed a commit
to XinFinOrg/XDPoSChain
that referenced
this pull request
Jun 28, 2024
This PR adds enode.LocalNode and integrates it into the p2p subsystem. This new object is the keeper of the local node record. For now, a new version of the record is produced every time the client restarts. We'll make it smarter to avoid that in the future. There are a couple of other changes in this commit: discovery now waits for all of its goroutines at shutdown and the p2p server now closes the node database after discovery has shut down. This fixes a leveldb crash in tests. p2p server startup is faster because it doesn't need to wait for the external IP query anymore.
wanwiset25
added a commit
to XinFinOrg/XDPoSChain
that referenced
this pull request
Aug 23, 2024
This reverts commit 3ca7a7c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
enode.LocalNode. This new object is the keeper of the local node record.For now, a new version of the record is produced every time the client restarts. We'll make it
smarter to avoid that in the future.