Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: update slow test lists, skip on windows/386 #17758

Merged
merged 1 commit into from
Sep 28, 2018
Merged

tests: update slow test lists, skip on windows/386 #17758

merged 1 commit into from
Sep 28, 2018

Conversation

fjl
Copy link
Contributor

@fjl fjl commented Sep 25, 2018 •
edited
Loading

This is my attempt to fix the tests on 32bit Windows. With this change, go test -short ./tests takes 12s on my rather slow Intel Core m3 laptop.

holiman
holiman approved these changes Sep 25, 2018
View reviewed changes
Copy link
Contributor

@holiman holiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if travis is green

@fjl fjl force-pushed the tests-windows branch 2 times, most recently from 9d9c9ef to e738709 Compare September 28, 2018 18:07
@fjl fjl merged commit 79ca6c7 into ethereum:master Sep 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holiman holiman holiman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fjl @holiman