swarm/storage: fix access count on dbstore after cache hit #17978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zelig
approved these changes
Oct 25, 2018
frncmx
force-pushed
the
cache-accesscnt-fix
branch
from
66ef1f6
to
28b03a3
Compare
|
Note: The simplification of the LDBStore.Close() will come in another PR. |
frncmx
force-pushed
the
cache-accesscnt-fix
branch
from
28b03a3
to
ade00d1
Compare
acud
reviewed
Nov 5, 2018
frncmx
force-pushed
the
cache-accesscnt-fix
branch
from
8a80f2a
to
9689003
Compare
zelig
approved these changes
Nov 12, 2018
nolash
suggested changes
Nov 12, 2018
zelig
approved these changes
Nov 12, 2018
Access count was not incremented when chunk was retrieved from cache. So the garbage collector might have deleted the most frequently accessed chunk from disk. Co-authored-by: Ferenc Szabo <ferenc.szabo@ethereum.org>
frncmx
force-pushed
the
cache-accesscnt-fix
branch
from
9689003
to
33c349b
Compare
nolash
approved these changes
Nov 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Access count was not incremented when chunk was retrieved
from cache. So the garbage collector might have deleted the most
frequently accessed chunk from disk.