Fix race in TestLDBStoreCollectGarbage and disable flaky testLDBStoreRemoveThenCollectGarbage #18512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the context parameter is not used and fixing it is not trivial, let's rather just drop that. Why is it not trivial? The usual select with <-ctx.Done() would not work, as ldb.gc.runC is always expected to have 1 element when the GC is not running. Also: #1151
Test fails unreliably when run with `-race` flag. As waitGC() does not work as expected, it might just continue (not block) if GC is not running already. We might end up with or without a chunk, depending on goroutine scheduling. As localstore rewrite is at the finish line and this blocks #741 => Skip.
janos
approved these changes
Jan 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes ethersphere/swarm#1118
TestLDBStoreCollectGarbagedata race fixed with locks (only needed in tests)testLDBStoreRemoveThenCollectGarbagefails unreliably when run with-raceflag. As waitGC() does not work as expected, it might just continue (not block) if GC is notrunning already. We might end up with or without a chunk, depending
on goroutine scheduling. As localstore rewrite is at the finish line and this blocks
ethersphere#741 => Skip.