travis.yml: add race detector job for Swarm #19148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
February 20, 2019 20:59
`go test -race ./swarm...` sometimes fails because there is no output produced for 10 minutes and Travis just aborts the build. As `t.Log()` holds the buffer until the test does not pass or fail.
We had more than a dozen of Data Races in our code base. Go has a nice builtin race detector tool. So we should have a CI job that at least notifies us timely if we introduce a new race. 1st let's just have a daily CRON job triggered on ethersphere/go-ethereum. Later as the job gets stable, we can start using it for ethersphere PRs. resolves: #741
As we only deal with artifacts in the upstream repo.
As we only deal with artifacts there and secretes are not even available on our forks.
As the completion time is around ~15m currently, so we can run it against every push/PR. Still, just on ethersphere.
3 tasks
janos
approved these changes
Feb 21, 2019
fjl
changed the title
kiku-jw
pushed a commit
to kiku-jw/go-ethereum
that referenced
this pull request
Mar 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had more than a dozen of Data Races in Swarm code base. Go has a nice builtin race detector tool. So we should have a CI job that leverages the tool.
Notes:
repo = ethereum/go-ethereum. That is just an improvement, I can let go. I noticed the mentioned job run on my fork, they still passed (strangely), but I did not have the credentials.resolves ethersphere/swarm#741
resolves ethersphere/swarm#1102