all: Add an error return value to NewEVM #19175
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gballet
requested review from
holiman,
karalabe and
zsfelfoldi
as code owners
Closed
gballet
force-pushed
the
newevm-returns-error
branch
from
c241661
to
84a66b6
Compare
gballet
force-pushed
the
newevm-returns-error
branch
from
84a66b6
to
3ac4b5f
Compare
|
We decided not to proceed with this, it is a requirement that all error-prone operations be made at startup time, before any call to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the introduction of EVMC some options passed during VM could make the process fail.
This introduces an
errorreturn value toNewEVMso that the VM creation doesn't have to panic. This is important, in case some instantiation during an RPC call (e.g. tracer) fails: we want the error to be reported to the RPC caller, while the main process (e.g. a full sync) continues.