p2p: Transmit ENR in RLPX handshake #19220
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolash
requested review from
janos,
acud,
nonsense and
zsfelfoldi
as code owners
|
I don't want to merge this, but I'm writing an EIP at the moment that includes this change. Will post here when the EIP is submitted. |
|
@fjl, oh, I see. So it is not at all certain that in the end the ENR record will be available over the RLPx handshake like this? (in protocol attributes, peerinfo)? |
|
I definitely want it available after the handshake, but protocol changes need to go through the specification/EIP process before being included. |
Great, and with that you mean available in this way? Because if you do, I can continue the work based on the pending change. |
This was referenced Mar 12, 2019
53 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on the work by @fjl in including the ENR record of a node in the RLPx handshake. The implementation is unchanged, but makes necessary adjustments for the thus broken tests to pass.
It also introduces the enr record in the nodeconfig in the simulations framework, so this is externally available when setting up services for use in a simulation.
A simple POC code example for transmitting a swarm bzz key over ENR making use of these changes can be found here:
https://gist.github.com/nolash/9434ea24a71474bebcd0341c98685ff4