consensus/ethash: fix a typo and error message #20503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karalabe
reviewed
Jan 6, 2020
consensus/ethash/consensus.go
Outdated
| @@ -68,7 +68,7 @@ var ( | |||
| // codebase, inherently breaking if the engine is swapped out. Please put common | |||
| // error types into the consensus package. | |||
| var ( | |||
| errZeroBlockTime = errors.New("timestamp equals parent's") | |||
| errOlderBlockTime = errors.New("header timestamp is older or same as parent's") | |||
There was a problem hiding this comment.
Perhaps timestamp older than parent. I know it's not as precise, but I kind of prefer shorter errors than long winded wording that doesn't add significantly more information.
fjl
approved these changes
Jan 7, 2020
7 tasks
enriquefynn
pushed a commit
to enriquefynn/go-ethereum
that referenced
this pull request
Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.