Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core, txpool: less allocations when handling transactions #21232

Merged
merged 8 commits into from
Jul 1, 2020
Merged

core, txpool: less allocations when handling transactions #21232

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e59dd01
core: added local tx pool test case
MariusVanDerWijden Jun 17, 2020
125a9e2
core: use uint64 for total tx costs instead of big.Int
MariusVanDerWijden Jun 17, 2020
90a2f2d
core, crypto: various allocation savings regarding tx handling
holiman Jun 17, 2020
b2f8a01
Update core/tx_list.go
holiman Jun 17, 2020
97cbad2
core: added tx.GasPriceIntCmp for comparison without allocation
MariusVanDerWijden Jun 17, 2020
44157d3
core: handle pools full of locals better
holiman Jun 17, 2020
2e39db1
core/tests: benchmark for tx_list
holiman Jun 17, 2020
0d5d33e
core/txlist, txpool: save a reheap operation, avoid some bigint allocs
holiman Jun 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update core/tx_list.go
  • Loading branch information
@holiman @MariusVanDerWijden
holiman authored and MariusVanDerWijden committed Jul 1, 2020
commit b2f8a012f5f4eb269a5e3104dd407d44466c3850
2 changes: 1 addition & 1 deletion core/tx_list.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ func (m *txSortedMap) Flatten() types.Transactions {
// transaction with the highest nonce
func (m *txSortedMap) LastElement() *types.Transaction {
cache := m.flatten()
return cache[len(m.cache)-1]
return cache[len(cache)-1]
}

// txList is a "list" of transactions belonging to an account, sorted by account
Expand Down