rpc: add SetHeader method to Client #21392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjl
reviewed
Jul 31, 2020
fjl
reviewed
Jul 31, 2020
fjl
reviewed
Jul 31, 2020
In go-ethereum, 'mu' and 'lock' are the canonical names for lock-typed fields.
This makes the test less reliant on client internals.
http.Header usually shouldn't be modified using map operations because it performs canonicalization on the key strings.
fjl
changed the title
SetHeaders method to Client
renaynay
commented
Aug 3, 2020
rpc/http.go
Outdated
| // set headers | ||
| hc.mu.Lock() | ||
| for key, vals := range hc.headers { | ||
| req.Header.Del(key) |
There was a problem hiding this comment.
I may be missing something, but why do you have to delete the key before setting the key & Vals even though the request is a fresh new request?
There was a problem hiding this comment.
Yeah, you're right, I got confused.
This was referenced Feb 24, 2021
enriquefynn
pushed a commit
to enriquefynn/go-ethereum
that referenced
this pull request
Mar 10, 2021
Resolves ethereum#20163 Co-authored-by: Felix Lange <fjl@twurst.com>
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #20163