eth: improve log message #22146
Merged
eth: improve log message #22146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MariusVanDerWijden
requested review from
holiman,
karalabe and
rjl493456442
as code owners
DGKSK8LIFE
approved these changes
Jan 7, 2021
holiman
reviewed
Jan 7, 2021
eth/handler.go
Outdated
|
|
||
| // Send the block to a subset of our peers | ||
| transfer := peers[:int(math.Sqrt(float64(len(peers))))] | ||
| for _, peer := range transfer { | ||
| txset[peer] = append(txset[peer], tx.Hash()) | ||
| } | ||
| log.Trace("Broadcast transaction", "hash", tx.Hash(), "recipients", len(peers)) | ||
| log.Trace("Broadcast transaction", "hash", tx.Hash(), "recipients", len(txset)) |
There was a problem hiding this comment.
That's not a typo fix -- pretty certain that changes the semantics of the message
There was a problem hiding this comment.
Yes, it changes the message from logging all peers to only logging the peers that we actually send the transaction to
There was a problem hiding this comment.
Not quite, does it? The len(txset) will grow for each transaction.. ?
So if txs are two transactoins, and tx1 is sent to peerA, then txset will have one key, peerA.
If tx2 is sent only to peerB, then the key peerB will be added to txset, and len(txset) will be 2, not 1.
I think what you want is len(transfer)
There was a problem hiding this comment.
Ahh I meant to put len(transfer), sorry
holiman
approved these changes
Jan 11, 2021
9 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also fixes a typo